Linux-PHY Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Stefan Dösinger" <stefandoesinger@gmail.com>
Cc: devicetree@vger.kernel.org, mfd@lists.linux.dev,
	linux-phy@lists.infradead.org, robh@kernel.org,
	conor+dt@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org,
	olteanv@gmail.com, lee@kernel.org
Subject: Re: [PATCH 4/6] phy: zte: Add a zx29 USB PHY driver.
Date: Fri, 20 Nov 2026 19:47:38 +0000	[thread overview]
Message-ID: <sashiko-outbox-225958@kernel.org> (raw)
In-Reply-To: <20261120-zx29usb-v1-4-b0433258e51b@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] phy: zte: OF node refcount leak in phy_zx29_probe() via wrong
  helper
--

commit 15ae50d59e0e993615e70ce4fb99a2131fc91c46
Author: Stefan Dösinger <stefandoesinger@gmail.com>

phy: zte: Add a zx29 USB PHY driver.

This commit adds a PHY driver for the ZTE zx29 USB and HSIC PHYs to
handle reset sequencing and ready status polling in the topcrm syscon.

> diff --git a/drivers/phy/phy-zx29-usb.c b/drivers/phy/phy-zx29-usb.c
> new file mode 100644
> index 0000000000000..8dfbcb468c263
> --- /dev/null
> +++ b/drivers/phy/phy-zx29-usb.c
[ ... ]
> +static int phy_zx29_probe(struct platform_device *pdev)
> +{
> +	struct phy_provider *phy_provider;
> +	struct device *dev = &pdev->dev;
> +	struct phy_zx29_drv_priv *priv;
> +	unsigned int i;
> +
> +	device_set_of_node_from_dev(dev, dev->parent);

[Severity: Medium]
Should this call platform_device_set_of_node_from_dev(pdev, dev->parent)
instead of device_set_of_node_from_dev()?

device_set_of_node_from_dev() takes a reference on dev->parent->of_node
and sets dev->of_node, but leaves pdev->dev.fwnode NULL.  When the
platform device is released, platform_device_release() drops
pa->pdev.dev.fwnode rather than dev->of_node, leaking the OF node
reference.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120-zx29usb-v1-0-b0433258e51b@gmail.com?part=4

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  reply	other threads:[~2026-11-20 19:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 19:20 [PATCH 0/6] ZTE zx297520v3 USB support Stefan Dösinger
2026-11-20 19:20 ` [PATCH 1/6] dt-bindings: soc: zte: Document zx297520v3 socsys controller Stefan Dösinger
2026-11-20 19:38   ` sashiko-bot
2026-11-20 19:20 ` [PATCH 2/6] mfd: zx297520v3: Add socsys to the mfd host driver Stefan Dösinger
2026-11-20 19:20 ` [PATCH 3/6] pmdomain: zte: Add a zx297520v3 power domain driver Stefan Dösinger
2026-11-20 19:51   ` sashiko-bot
2026-11-20 19:20 ` [PATCH 4/6] phy: zte: Add a zx29 USB PHY driver Stefan Dösinger
2026-11-20 19:47   ` sashiko-bot [this message]
2026-11-20 19:20 ` [PATCH 5/6] ARM: dts: zte: Declare nodes to enable the board's dwc2 controller Stefan Dösinger
2026-11-20 19:20 ` [PATCH 6/6] ARM: dts: zte: Declare the HSIC controller node Stefan Dösinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-225958@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=mfd@lists.linux.dev \
    --cc=neil.armstrong@linaro.org \
    --cc=olteanv@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=stefandoesinger@gmail.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox