linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: <josephjang@google.com>
To: gregkh@linuxfoundation.org, rafael@kernel.org, rjw@rjwysocki.net,
	pavel@ucw.cz, len.brown@intel.com, pmladek@suse.com,
	sergey.senozhatsky@gmail.com, rostedt@goodmis.org
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	jonglin@google.com, woodylin@google.com, markcheng@google.com,
	josephjang@google.com
Subject: [PATCH v2] power: suspend: Replace dpm_watchdog by sleep timer
Date: Wed, 21 Oct 2020 10:04:24 +0000	[thread overview]
Message-ID: <000000000000da35b205b22b7886@google.com> (raw)

> On Wed, Oct 21, 2020 at 4:09 AM Joseph Jang <josephjang@google.com> wrote:
> >
> > Since dpm_watchdog just cover device power management, we proposed sleep
> > timer to cover not only device power management hang issues, but also
> > core power management hand issue.
> >
> > Add sleep timer and timeout handler to prevent device stuck during  
> suspend/
> > resume process. The timeout handler will dump disk sleep task at first
> > round timeout and trigger kernel panic at second round timeout.
> > The default timer for each round is defined in
> > CONFIG_PM_SLEEP_TIMER_TIMEOUT.

> Let me repeat the point that Greg has made already: Please don't
> replace the existing watchdog with something else, but try to extend
> it to cover your use case.

> As it stands, the patch is not applicable IMV.

> Thanks!

Thank you Rafael's promptly response.
Since dmp_watchdog was implement in drivers/base/power/main.c and it use  
stack memory for timer struct.
It is a little bit hard to use its API in kernel/power/suspend.c.
And from the call flow, we prefer to start/stop watchog timer in suspend.c  
only. It will also cover device
power management as well.

If you don't want to change Kconfig, I can keep original DPM_WATCHDOG.
But it is not easy to extend driver base API into core power base. Am I  
correct?

If you have some suggestion, please feel free to let me know, I will follow  
up.

Thank you,
Joseph.

             reply	other threads:[~2020-10-21 10:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-21 10:04 josephjang [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-10-21 12:01 [PATCH v2] power: suspend: Replace dpm_watchdog by sleep timer josephjang
2020-10-21  2:09 Joseph Jang
2020-10-21  9:51 ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=000000000000da35b205b22b7886@google.com \
    --to=josephjang@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jonglin@google.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=markcheng@google.com \
    --cc=pavel@ucw.cz \
    --cc=pmladek@suse.com \
    --cc=rafael@kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=woodylin@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).