From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCCEFC4363A for ; Wed, 21 Oct 2020 10:04:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3564122249 for ; Wed, 21 Oct 2020 10:04:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="MqvHRVZi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2409452AbgJUKEZ (ORCPT ); Wed, 21 Oct 2020 06:04:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2409397AbgJUKEZ (ORCPT ); Wed, 21 Oct 2020 06:04:25 -0400 Received: from mail-pj1-x1049.google.com (mail-pj1-x1049.google.com [IPv6:2607:f8b0:4864:20::1049]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46271C0613CF for ; Wed, 21 Oct 2020 03:04:25 -0700 (PDT) Received: by mail-pj1-x1049.google.com with SMTP id v10so968812pjk.7 for ; Wed, 21 Oct 2020 03:04:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:mime-version:message-id:date:subject:from:to:cc; bh=c4CgoA3uOwuCr6KU0k3hWITFaxS6qaraKmWsHEdQhco=; b=MqvHRVZiQIdY6WKux6bIJxrvQVnEjCV8A4u3M2nSM8dRjWRdXtWVkC31qhqccIzZzl 2IZelX9v7KTcHiKwpiOKSHDpbfkFikgtttK4H05Ei8oJ4fFySgM1XCoxllTJJEKEuj04 1z51Sb3JWdIQmp7TlJKC0zy1gjlagiY6oDenhnkSqWnYgQjgYZ+fsDyPbWVEAFVEJNwm 3hdUU+/qEaR405p1BkPM4w6f3HR0Uv1Y7Arm9SapSy2y39vtUYVAHuN/kyoxOKeCo7Sf aOcMDLHz6XbpZha5EVQPFDPp/UtZjpwqfw36fPOVWLa9V/b41oWNC2jXioP87Q5hvgWt 3XRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:mime-version:message-id:date:subject:from :to:cc; bh=c4CgoA3uOwuCr6KU0k3hWITFaxS6qaraKmWsHEdQhco=; b=hHBrBYfqM2okPuQAJjfc5kpq3fuLljMHxmu0xeE2SrZde0Ga90boFOcz5Rhsp+9fIk 3+FUuC0EBLRC+6eDq1a/YTqYziQNnZKZlY+x9Gcff0o2SrO207pm71ooyuDlFHJxIMZ6 PRqqb3h8vtuQSl8L9eU7/wzRtBG6Ts6+FhXmC7+cZp9OwrqzZeMDETmJaZ1RnntxalmB wg5yeBdovGvEY94fo9p2fkiLvtDuGruwro+JZ1BK1mMuG+Lt+ydZWJj5DsEOIlauD6sN /u1l2z1cGiX5YI+sE/jhNTL4tHpWZULQg7Pe4iiEyJIqB/q3U/GZn6arAjN/wIvwWWGX 7POQ== X-Gm-Message-State: AOAM53165QzBaBo5kZuJIz0Iqk5wptNNB/d5j0AYoFSBjSVt67Rn+Ofe A6gCNMxbJFznZxY7Iqe0+f5YcTDRD4WJ1ty6 X-Google-Smtp-Source: ABdhPJx0IttQCRs+PAdvXuWAbiLgj6p1WBRQnJIH6pqMrFeTRASQk6f2ZlcsMCYnX5JyV+bcZWIqO1tjqOtQxNRJ Sender: "josephjang via sendgmr" MIME-Version: 1.0 X-Received: from josephjang-p920.ntc.corp.google.com ([2401:fa00:fc:1:7220:84ff:fe09:41e0]) (user=josephjang job=sendgmr) by 2002:a62:75d6:0:b029:152:6ead:63fa with SMTP id q205-20020a6275d60000b02901526ead63famr2824816pfc.38.1603274664428; Wed, 21 Oct 2020 03:04:24 -0700 (PDT) Message-ID: <000000000000da35b205b22b7886@google.com> Date: Wed, 21 Oct 2020 10:04:24 +0000 Subject: [PATCH v2] power: suspend: Replace dpm_watchdog by sleep timer From: To: gregkh@linuxfoundation.org, rafael@kernel.org, rjw@rjwysocki.net, pavel@ucw.cz, len.brown@intel.com, pmladek@suse.com, sergey.senozhatsky@gmail.com, rostedt@goodmis.org Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, jonglin@google.com, woodylin@google.com, markcheng@google.com, josephjang@google.com Content-Type: text/plain; charset="UTF-8"; format=flowed; delsp=yes Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org > On Wed, Oct 21, 2020 at 4:09 AM Joseph Jang wrote: > > > > Since dpm_watchdog just cover device power management, we proposed sleep > > timer to cover not only device power management hang issues, but also > > core power management hand issue. > > > > Add sleep timer and timeout handler to prevent device stuck during > suspend/ > > resume process. The timeout handler will dump disk sleep task at first > > round timeout and trigger kernel panic at second round timeout. > > The default timer for each round is defined in > > CONFIG_PM_SLEEP_TIMER_TIMEOUT. > Let me repeat the point that Greg has made already: Please don't > replace the existing watchdog with something else, but try to extend > it to cover your use case. > As it stands, the patch is not applicable IMV. > Thanks! Thank you Rafael's promptly response. Since dmp_watchdog was implement in drivers/base/power/main.c and it use stack memory for timer struct. It is a little bit hard to use its API in kernel/power/suspend.c. And from the call flow, we prefer to start/stop watchog timer in suspend.c only. It will also cover device power management as well. If you don't want to change Kconfig, I can keep original DPM_WATCHDOG. But it is not easy to extend driver base API into core power base. Am I correct? If you have some suggestion, please feel free to let me know, I will follow up. Thank you, Joseph.