public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: Jingoo Han <jg1.han@samsung.com>
To: 'Zhang Rui' <rui.zhang@intel.com>
Cc: 'Eduardo Valentin' <eduardo.valentin@ti.com>,
	linux-pm@vger.kernel.org,
	'Ezequiel Garcia' <ezequiel.garcia@free-electrons.com>,
	Jingoo Han <jg1.han@samsung.com>
Subject: Re: [PATCH 1/6] thermal: armada: remove unnecessary platform_set_drvdata()
Date: Tue, 07 May 2013 09:09:47 +0900	[thread overview]
Message-ID: <000601ce4ab7$2f696530$8e3c2f90$@samsung.com> (raw)
In-Reply-To: <1367850754.2079.50.camel@rzhang1-mobl4>

On Monday, May 06, 2013 11:33 PM, Zhang Rui wrote:
> On Mon, 2013-05-06 at 13:26 +0900, Jingoo Han wrote:
> > The driver core clears the driver data to NULL after device_release
> > or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> > (device-core: Ensure drvdata = NULL when no driver is bound).
> > Thus, it is not needed to manually clear the device driver data to NULL.
> >
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> 
> it seems that we already have a patchset for this issue.
> please check https://patchwork.kernel.org/patch/2516651/

OK, I see.
These patches seem to be already submitted.
Thank you.

Best regards,
Jingoo Han

> 
> thanks,
> rui
> > ---
> >  drivers/thermal/armada_thermal.c |    1 -
> >  1 files changed, 0 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c
> > index 5b4d75f..0d02d4e 100644
> > --- a/drivers/thermal/armada_thermal.c
> > +++ b/drivers/thermal/armada_thermal.c
> > @@ -210,7 +210,6 @@ static int armada_thermal_exit(struct platform_device *pdev)
> >  		platform_get_drvdata(pdev);
> >
> >  	thermal_zone_device_unregister(armada_thermal);
> > -	platform_set_drvdata(pdev, NULL);
> >
> >  	return 0;
> >  }



      reply	other threads:[~2013-05-07  0:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-06  4:26 [PATCH 1/6] thermal: armada: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-06 14:32 ` Zhang Rui
2013-05-07  0:09   ` Jingoo Han [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000601ce4ab7$2f696530$8e3c2f90$@samsung.com' \
    --to=jg1.han@samsung.com \
    --cc=eduardo.valentin@ti.com \
    --cc=ezequiel.garcia@free-electrons.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox