* [PATCH 2/2] cpuidle: kirkwood: Staticize local symbol
@ 2013-08-09 7:11 Jingoo Han
2013-08-09 11:37 ` Jason Cooper
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-08-09 7:11 UTC (permalink / raw)
To: 'Rafael J. Wysocki'
Cc: 'Daniel Lezcano', linux-pm, Jason Cooper,
'Silviu-Mihai Popescu', Jingoo Han
This local symbol is used only in this file.
Fix the following sparse warnings:
drivers/cpuidle/cpuidle-kirkwood.c:73:5: warning: symbol 'kirkwood_cpuidle_remove' was not declared. Should it be static?
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/cpuidle/cpuidle-kirkwood.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpuidle/cpuidle-kirkwood.c b/drivers/cpuidle/cpuidle-kirkwood.c
index 521b0a7..3ca3a2e 100644
--- a/drivers/cpuidle/cpuidle-kirkwood.c
+++ b/drivers/cpuidle/cpuidle-kirkwood.c
@@ -70,7 +70,7 @@ static int kirkwood_cpuidle_probe(struct platform_device *pdev)
return cpuidle_register(&kirkwood_idle_driver, NULL);
}
-int kirkwood_cpuidle_remove(struct platform_device *pdev)
+static int kirkwood_cpuidle_remove(struct platform_device *pdev)
{
cpuidle_unregister(&kirkwood_idle_driver);
return 0;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] cpuidle: kirkwood: Staticize local symbol
2013-08-09 7:11 [PATCH 2/2] cpuidle: kirkwood: Staticize local symbol Jingoo Han
@ 2013-08-09 11:37 ` Jason Cooper
0 siblings, 0 replies; 2+ messages in thread
From: Jason Cooper @ 2013-08-09 11:37 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Rafael J. Wysocki', 'Daniel Lezcano', linux-pm,
'Silviu-Mihai Popescu'
On Fri, Aug 09, 2013 at 04:11:34PM +0900, Jingoo Han wrote:
> This local symbol is used only in this file.
> Fix the following sparse warnings:
>
> drivers/cpuidle/cpuidle-kirkwood.c:73:5: warning: symbol 'kirkwood_cpuidle_remove' was not declared. Should it be static?
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/cpuidle/cpuidle-kirkwood.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Jason Cooper <jason@lakedaemon.net>
thx,
Jason.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-09 11:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-09 7:11 [PATCH 2/2] cpuidle: kirkwood: Staticize local symbol Jingoo Han
2013-08-09 11:37 ` Jason Cooper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox