linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Doug Smythies" <dsmythies@telus.net>
To: "'Vincent Guittot'" <vincent.guittot@linaro.org>,
	"'Peter Zijlstra'" <peterz@infradead.org>
Cc: "'linux-kernel'" <linux-kernel@vger.kernel.org>,
	"'Ingo Molnar'" <mingo@redhat.com>,
	"'Dietmar Eggemann'" <dietmar.eggemann@arm.com>,
	"'Juri Lelli'" <juri.lelli@redhat.com>,
	"'Steven Rostedt'" <rostedt@goodmis.org>,
	"'Mel Gorman'" <mgorman@suse.de>,
	"'open list:THERMAL'" <linux-pm@vger.kernel.org>,
	"'Linus Torvalds'" <torvalds@linux-foundation.org>,
	"'Thomas Gleixner'" <tglx@linutronix.de>,
	"'Sargun Dhillon'" <sargun@sargun.me>,
	"'Tejun Heo'" <tj@kernel.org>,
	"'Xie XiuQi'" <xiexiuqi@huawei.com>, <xiezhipeng1@huawei.com>,
	"'Srinivas Pandruvada'" <srinivas.pandruvada@linux.intel.com>
Subject: RE: [PATCH v4] sched/freq: move call to cpufreq_update_util
Date: Sat, 16 Nov 2019 07:07:49 -0800	[thread overview]
Message-ID: <000601d59c8f$9fa191c0$dee4b540$@net> (raw)
In-Reply-To: <CAKfTPtDyZ5gom41S-8Nu+BMK7hPijWoZPqo0HFYkRnNmWo1UTA@mail.gmail.com>

Hi,

I tested both Vincent's V4 and Peter's, I called it V1.

8000 seconds intel_pstate_tracer on a very idle system.
Everything was fine.

Vincent-V4:

Maximum time between calls to the intel_pstate driver,
per CPU: 4.00813 seconds: GOOD/PASS

Total entries/exits to/from driver: 90,730:
Consistent with previous tests / expectations.

228,600 aperf clocks / second / cpu.  
Consistent with previous tests / expectations.

Peter-V1:

Maximum time between calls to the intel_pstate driver,
per CPU: 4.00407 seconds: GOOD/PASS

Total entries/exits to/from driver: 96,440:
Consistent with previous tests / expectations.

241,310 aperf clocks / second / cpu.  
Consistent with previous tests / expectations.

Baseline reference:

Maximum time between calls to the intel_pstate driver,
per CPU: 225.03 seconds: BAD/FAIL

Number of durations over an arbitrary threshold of
10 seconds: 379.

Total entries/exits to/from driver: 75,969:
Consistent with previous tests / expectations,
when the issue is present.

226,963 aperf clocks / second / cpu.
Consistent with previous tests / expectations.

I did not do the load no-load energy test.
It is not possible for it to be a problem
if the long duration issue is solved.
I'll do the test, if someone wants the proof.

Kernels were 5.4-rc7 + linux next.
Idle governor was TEO, but this isn't actually relevant.

Tested-by: Doug Smythies <dsmythies@telus.net>

... Doug



      reply	other threads:[~2019-11-16 15:07 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-14 17:07 [PATCH v4] sched/freq: move call to cpufreq_update_util Vincent Guittot
2019-11-15  9:54 ` Peter Zijlstra
2019-11-15 10:03   ` Rafael J. Wysocki
2019-11-15 10:40     ` Peter Zijlstra
2019-11-15 11:05       ` Vincent Guittot
2019-11-15 10:18   ` Vincent Guittot
2019-11-15 10:29     ` Vincent Guittot
2019-11-15 11:59       ` Vincent Guittot
2019-11-15 12:25         ` Vincent Guittot
2019-11-15 10:37     ` Peter Zijlstra
2019-11-15 10:46       ` Vincent Guittot
2019-11-15 10:51         ` Peter Zijlstra
2019-11-15 11:03           ` Vincent Guittot
2019-11-15 11:56             ` Peter Zijlstra
2019-11-15 13:01             ` Peter Zijlstra
2019-11-15 13:30               ` Vincent Guittot
2019-11-15 13:46                 ` Peter Zijlstra
2019-11-15 15:30               ` Doug Smythies
2019-11-15 10:51         ` Rafael J. Wysocki
2019-11-15 12:17         ` Peter Zijlstra
2019-11-15 11:46 ` Rafael J. Wysocki
2019-11-15 13:25 ` Peter Zijlstra
2019-11-15 13:37   ` Vincent Guittot
2019-11-15 14:05     ` Peter Zijlstra
2019-11-15 14:12       ` Vincent Guittot
2019-11-15 15:12     ` Peter Zijlstra
2019-11-15 15:31       ` Vincent Guittot
2019-11-15 17:43         ` Peter Zijlstra
2019-11-15 18:00           ` Vincent Guittot
2019-11-15 20:12             ` Peter Zijlstra
2019-11-15 21:52 ` Peter Zijlstra
2019-11-16  8:47   ` Vincent Guittot
2019-11-16 15:07     ` Doug Smythies [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000601d59c8f$9fa191c0$dee4b540$@net' \
    --to=dsmythies@telus.net \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=sargun@sargun.me \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=vincent.guittot@linaro.org \
    --cc=xiexiuqi@huawei.com \
    --cc=xiezhipeng1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).