From: "Doug Smythies" <dsmythies@telus.net>
To: "'Hanjun Guo'" <guohanjun@huawei.com>
Cc: <linux-pm@vger.kernel.org>, "'Jonathan Corbet'" <corbet@lwn.net>,
"'Rafael J. Wysocki'" <rjw@rjwysocki.net>,
"'Daniel Lezcano'" <daniel.lezcano@linaro.org>
Subject: RE: [RFC v2 PATCH 0/6] cpuidle: Make cpuidle governor switchable to be the default behaviour
Date: Tue, 12 May 2020 14:17:52 -0700 [thread overview]
Message-ID: <000b01d628a2$ce0a1ab0$6a1e5010$@net> (raw)
In-Reply-To: <1588235987-12300-1-git-send-email-guohanjun@huawei.com>
On 2020.04.30 01:40 Hanjun Guo wrote:
> For now cpuidle governor can be switched via sysfs only when the
> boot option "cpuidle_sysfs_switch" is passed, but it's important
>to switch the governor to adapt to different workloads, especially
> after TEO and haltpoll governor were introduced.
>
> Make cpuidle governor switchable to be the default behaviour by removing
> the sysfs_switch and switch attributes, also update the document as well.
>
> v1->v2:
> - Add two bugfix patch which can be triggered if the governor name is 15
> characters, it is not a 'real' bug for now as we don't have such usecases
> so we can merge them together via this patchset.
> - Remove the sysfs_switch, not introduce a CONFIG option to make cpuidle
> governor switchable in default, suggested by Daniel.
> - Update the document after cpuidle_sysfs_switch is removed, suggested by
> Doug Smythies.
>
> Hanjun Guo (6):
> cpuidle: sysfs: Fix the overlap for showing available governors
> cpuidle: sysfs: Accept governor name with 15 characters
> cpuidle: Make cpuidle governor switchable to be the default behaviour
> cpuidle: sysfs: Remove sysfs_switch and switch attributes
> Documentation: cpuidle: update the document
> Documentation: ABI: make current_governer_ro as a candidate for
> removal
>
> Documentation/ABI/obsolete/sysfs-cpuidle | 9 ++++
> Documentation/ABI/testing/sysfs-devices-system-cpu | 24 ++++------
> Documentation/admin-guide/pm/cpuidle.rst | 20 ++++----
> Documentation/driver-api/pm/cpuidle.rst | 5 +-
> drivers/cpuidle/sysfs.c | 56 ++++++----------------
> 5 files changed, 44 insertions(+), 70 deletions(-)
> create mode 100644 Documentation/ABI/obsolete/sysfs-cpuidle
Thanks,
Reviewed and tested by Doug Smythies <dsmythies@telus.net>
prev parent reply other threads:[~2020-05-12 21:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 8:39 [RFC v2 PATCH 0/6] cpuidle: Make cpuidle governor switchable to be the default behaviour Hanjun Guo
2020-04-30 8:39 ` [RFC v2 PATCH 1/6] cpuidle: sysfs: Fix the overlap for showing available governors Hanjun Guo
2020-05-18 14:20 ` Daniel Lezcano
2020-05-19 1:59 ` Hanjun Guo
2020-04-30 8:39 ` [RFC v2 PATCH 2/6] cpuidle: sysfs: Accept governor name with 15 characters Hanjun Guo
2020-04-30 8:39 ` [RFC v2 PATCH 3/6] cpuidle: Make cpuidle governor switchable to be the default behaviour Hanjun Guo
2020-05-18 14:24 ` Daniel Lezcano
2020-04-30 8:39 ` [RFC v2 PATCH 4/6] cpuidle: sysfs: Remove sysfs_switch and switch attributes Hanjun Guo
2020-05-18 20:19 ` Daniel Lezcano
2020-04-30 8:39 ` [RFC v2 PATCH 5/6] Documentation: cpuidle: update the document Hanjun Guo
2020-04-30 8:39 ` [RFC v2 PATCH 6/6] Documentation: ABI: make current_governer_ro as a candidate for removal Hanjun Guo
2020-05-18 14:27 ` Daniel Lezcano
2020-05-19 2:04 ` Hanjun Guo
2020-05-12 21:17 ` Doug Smythies [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000b01d628a2$ce0a1ab0$6a1e5010$@net' \
--to=dsmythies@telus.net \
--cc=corbet@lwn.net \
--cc=daniel.lezcano@linaro.org \
--cc=guohanjun@huawei.com \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).