RE: turbostat 2024.04.08 queued for upstream

["Doug Smythies" <dsmythies@telus.net>]

Hi Len,

Thank you for the new version of turbostat.
There seems to be 5 patches missing from the set of 26.
I also checked on patchworks:

https://patchwork.kernel.org/project/linux-pm/list/?series=842622


On 2024.04.08 17:31 Len wrote:

> Please let me know if you see any problems in this update.
>
> thanks!
> -len
>
> git://git.kernel.org/pub/scm/linux/kernel/git/lenb/linux.git tags/turbostat-2024.04.08

I cloned it and all 26 patches are there. 
I would just compile turbostat there and use that one, but it doesn't compile.
(see below).

>
> Turbostat version 2024.04.08
>
>Use of the CPU MSR driver is now optional.
> Perf is now preferred for many counters.
>
> Non-root users can now execute turbostat, though with limited function.
>
> Add counters for some new GFX hardware.
>
> ----------------------------------------------------------------
> Chen Yu (1):
>      tools/power turbostat: Do not print negative LPI residency
>
> Doug Smythies (1):
>      tools/power turbostat: Fix added raw MSR output
>
> Justin Ernst (1):
>      tools/power/turbostat: Fix uncore frequency file string

Missing.

> Len Brown (4):
>      tools/power turbostat: Expand probe_intel_uncore_frequency()
>      tools/power turbostat: Fix warning upon failed /dev/cpu_dma_latency read
>      tools/power turbostat: enhance -D (debug counter dump) output
>      tools/power turbostat: v2024.04.08

Missing (just tools/power turbostat: v2024.04.08 is missing)

This chunk of the patch:

 @@ -3371,7 +3374,7 @@ int get_rapl_counters(int cpu, int domain, struct core_data *c, struct pkg_data
        struct rapl_counter_info_t *rci = &rapl_counter_info_perdomain[domain];

        if (debug)
-               fprintf(stderr, "get_rapl_counters: cpu%d domain%d\n", cpu, domain);
+               fprintf(stderr, "%s: cpu%d domain%d\n" __func__, cpu, domain);

        assert(rapl_counter_info_perdomain);

Should be this (note the missing comma added):

+               fprintf(stderr, "%s: cpu%d domain%d\n", __func__, cpu, domain);

With that change turbostat version 2024.04.08 compiles.

> Patryk Wlazlyn (11):
>      tools/power turbostat: Print ucode revision only if valid
>      tools/power turbostat: Read base_hz and bclk from CPUID.16H if available
>      tools/power turbostat: Add --no-msr option
>      tools/power turbostat: Add --no-perf option
>      tools/power turbostat: Add reading aperf and mperf via perf API
>      tools/power turbostat: detect and disable unavailable BICs at runtime
>      tools/power turbostat: add early exits for permission checks
>      tools/power turbostat: Clear added counters when in no-msr mode
>      tools/power turbostat: Add proper re-initialization for perf file descriptors
>      tools/power turbostat: read RAPL counters via perf
>      tools/power turbostat: Add selftests
>
> Peng Liu (1):
>      tools/power turbostat: Fix Bzy_MHz documentation typo
>
> Wyes Karny (1):
>      tools/power turbostat: Increase the limit for fd opened
>
> Zhang Rui (6):
>      tools/power/turbostat: Enable MSR_CORE_C1_RES support for ICX
>      tools/power/turbostat: Cache graphics sysfs path
>      tools/power/turbostat: Unify graphics sysfs snapshots
>      tools/power/turbostat: Introduce BIC_SAM_mc6/BIC_SAMMHz/BIC_SAMACTMHz

Missing

>      tools/power/turbostat: Add support for new i915 sysfs knobs

Missing

>      tools/power/turbostat: Add support for Xe sysfs knobs

Missing

>
> MAINTAINERS                                     |    1 +
> tools/power/x86/turbostat/turbostat.8           |    6 +-
> tools/power/x86/turbostat/turbostat.c           | 2197 ++++++++++++++++++-----
> tools/testing/selftests/turbostat/defcolumns.py |   60 +
> 4 files changed, 1805 insertions(+), 459 deletions(-)
> create mode 100755 tools/testing/selftests/turbostat/defcolumns.py