From: Jingoo Han <jg1.han@samsung.com>
To: 'Tomasz Figa' <t.figa@samsung.com>
Cc: 'linux-samsung-soc' <linux-samsung-soc@vger.kernel.org>,
'linux-arm-kernel' <linux-arm-kernel@lists.infradead.org>,
cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
'Sachin Kamat' <sachin.kamat@linaro.org>,
'Kukjin Kim' <kgene.kim@samsung.com>,
'Russell King - ARM Linux' <linux@arm.linux.org.uk>,
'Viresh Kumar' <viresh.kumar@linaro.org>,
"'Rafael J. Wysocki'" <rjw@rjwysocki.net>,
'Lukasz Majewski' <l.majewski@samsung.com>,
'Kyungmin Park' <kyungmin.park@samsung.com>,
'Jingoo Han' <jg1.han@samsung.com>
Subject: Re: [PATCH] cpufreq: exynos: Convert exynos-cpufreq to platform driver
Date: Thu, 17 Oct 2013 17:31:52 +0900 [thread overview]
Message-ID: <001d01cecb13$54ccd410$fe667c30$%han@samsung.com> (raw)
In-Reply-To: <CAK9yfHwW+ofX5f8hHF=MYQn=CUMyiHvg4iAH-cHFW7JQ5Qnscw@mail.gmail.com>
On Thursday, October 17, 2013 2:00 PM, Sachin Kamat wrote:
> On 16 October 2013 21:30, Tomasz Figa <t.figa@samsung.com> wrote:
> > From: Lukasz Majewski <l.majewski@samsung.com>
> >
> > +static struct platform_driver exynos_cpufreq_platdrv = {
> > + .driver = {
> > + .name = "exynos-cpufreq",
> > + .owner = THIS_MODULE,
> > + },
> > + .probe = exynos_cpufreq_init,
>
> I think the prototype of this function should be changed to:
> static int __init exynos_cpufreq_init(struct platform_device *pdev)
>
> to avoid compilation warnings.
Hi Tomasz Figa,
One more thing. :-)
It makes section mismatch warning. Also, module_platform_driver()
is used. Then, '__init' annotation can be removed in order to fix
the section mismatch warning.
static int exynos_cpufreq_init(struct platform_device *pdev)
Thank you.
Best regards,
Jingoo Han
next prev parent reply other threads:[~2013-10-17 8:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 16:00 [PATCH] cpufreq: exynos: Convert exynos-cpufreq to platform driver Tomasz Figa
2013-10-17 4:59 ` Sachin Kamat
2013-10-17 8:31 ` Jingoo Han [this message]
2013-11-28 11:35 ` [PATCH v2] " Lukasz Majewski
2013-11-28 11:40 ` Sachin Kamat
2013-11-28 12:42 ` [PATCH v3] " Lukasz Majewski
2013-11-29 5:45 ` Sachin Kamat
2013-12-09 8:28 ` Lukasz Majewski
2013-12-16 9:13 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001d01cecb13$54ccd410$fe667c30$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=cpufreq@vger.kernel.org \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=l.majewski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rjw@rjwysocki.net \
--cc=sachin.kamat@linaro.org \
--cc=t.figa@samsung.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox