From mboxrd@z Thu Jan 1 00:00:00 1970 From: "myungjoo.ham" Subject: RE: [RESEND][PATCH 1/3] PM / devfreq: exynos4_bus: Fix missing mutex_unlock if opp_find_freq_floor fails Date: Fri, 12 Apr 2013 21:11:00 +0900 Message-ID: <002101ce3776$cbc83f90$6358beb0$@samsung.com> References: <1365746058.4025.1.camel@phoenix> <1413655.hhUbBAKNUi@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mailout1.samsung.com ([203.254.224.24]:33656 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752878Ab3DLMLC convert rfc822-to-8bit (ORCPT ); Fri, 12 Apr 2013 08:11:02 -0400 In-reply-to: <1413655.hhUbBAKNUi@vostro.rjw.lan> Content-language: ko Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: "'Rafael J. Wysocki'" , 'Axel Lin' , 'Kyungmin Park' , 'Kukjin Kim' Cc: "'Rafael J. Wysocki'" , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org > On Friday, April 12, 2013 11:52:01 AM =ED=95=A8=EB=AA=85=EC=A3=BC wro= te: > > > On Friday, April 12, 2013 01:54:18 PM Axel Lin wrote: > > > > We need to call mutex_unlock() in the error path. > > > >=20 > > > > Signed-off-by: Axel Lin > > >=20 > > > All three patches applied to linux-pm.git/linux-next. > > >=20 > > > Exynos maintainers, if you have any objections, please holler. > > >=20 > > > Thanks, > > > Rafael > >=20 > > This patch was included in the last pull-request patchset > > though the path was updated. (its precedessor patch moved > > exynos drivers to /drivers/devfreq/exynos/* after adding > > Exynos common driver files) >=20 > OK, so do you want me to drop it? >=20 > What about the remaining two? Yes, please drop 1/3. It's duplicated. The patches 2~3/3 can wait. They are actually not bugfixes. >=20 > Do you have any more devfreq patches for me to take into v3.10? If s= o, > please send a pull request ASAP. >=20 > Thanks, > Rafael >=20 >=20 > > >=20 > > > > --- > > > > drivers/devfreq/exynos4_bus.c | 3 ++- > > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > >=20 > > > > diff --git a/drivers/devfreq/exynos4_bus.c b/drivers/devfreq/ex= ynos4_bus.c > > > > index 1deee09..54b9615 100644 > > > > --- a/drivers/devfreq/exynos4_bus.c > > > > +++ b/drivers/devfreq/exynos4_bus.c > > > > @@ -974,7 +974,8 @@ static int exynos4_busfreq_pm_notifier_even= t(struct notifier_block *this, > > > > rcu_read_unlock(); > > > > dev_err(data->dev, "%s: unable to find a min freq\n", > > > > __func__); > > > > - return PTR_ERR(opp); > > > > + err =3D PTR_ERR(opp); > > > > + goto unlock; > > > > } > > > > new_oppinfo.rate =3D opp_get_freq(opp); > > > > new_oppinfo.volt =3D opp_get_voltage(opp); > > > >=20 > > > --=20 > > > I speak only for myself. > > > Rafael J. Wysocki, Intel Open Source Technology Center. > > >=20 > > >=20 > > >=20 > > > =20 > > > =20 > > > =20 > > >=20 >=20 > --=20 > I speak only for myself. > Rafael J. Wysocki, Intel Open Source Technology Center. >=20 >=20 >=20 > =20 > =20 > =20 >