* [PATCH 1/6] thermal: armada: remove unnecessary platform_set_drvdata()
@ 2013-05-06 4:26 Jingoo Han
2013-05-06 14:32 ` Zhang Rui
0 siblings, 1 reply; 3+ messages in thread
From: Jingoo Han @ 2013-05-06 4:26 UTC (permalink / raw)
To: 'Zhang Rui'
Cc: 'Eduardo Valentin', linux-pm, Jingoo Han,
'Ezequiel Garcia'
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/thermal/armada_thermal.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c
index 5b4d75f..0d02d4e 100644
--- a/drivers/thermal/armada_thermal.c
+++ b/drivers/thermal/armada_thermal.c
@@ -210,7 +210,6 @@ static int armada_thermal_exit(struct platform_device *pdev)
platform_get_drvdata(pdev);
thermal_zone_device_unregister(armada_thermal);
- platform_set_drvdata(pdev, NULL);
return 0;
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/6] thermal: armada: remove unnecessary platform_set_drvdata()
2013-05-06 4:26 [PATCH 1/6] thermal: armada: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-06 14:32 ` Zhang Rui
2013-05-07 0:09 ` Jingoo Han
0 siblings, 1 reply; 3+ messages in thread
From: Zhang Rui @ 2013-05-06 14:32 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Eduardo Valentin', linux-pm, 'Ezequiel Garcia'
On Mon, 2013-05-06 at 13:26 +0900, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
it seems that we already have a patchset for this issue.
please check https://patchwork.kernel.org/patch/2516651/
thanks,
rui
> ---
> drivers/thermal/armada_thermal.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c
> index 5b4d75f..0d02d4e 100644
> --- a/drivers/thermal/armada_thermal.c
> +++ b/drivers/thermal/armada_thermal.c
> @@ -210,7 +210,6 @@ static int armada_thermal_exit(struct platform_device *pdev)
> platform_get_drvdata(pdev);
>
> thermal_zone_device_unregister(armada_thermal);
> - platform_set_drvdata(pdev, NULL);
>
> return 0;
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/6] thermal: armada: remove unnecessary platform_set_drvdata()
2013-05-06 14:32 ` Zhang Rui
@ 2013-05-07 0:09 ` Jingoo Han
0 siblings, 0 replies; 3+ messages in thread
From: Jingoo Han @ 2013-05-07 0:09 UTC (permalink / raw)
To: 'Zhang Rui'
Cc: 'Eduardo Valentin', linux-pm, 'Ezequiel Garcia',
Jingoo Han
On Monday, May 06, 2013 11:33 PM, Zhang Rui wrote:
> On Mon, 2013-05-06 at 13:26 +0900, Jingoo Han wrote:
> > The driver core clears the driver data to NULL after device_release
> > or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> > (device-core: Ensure drvdata = NULL when no driver is bound).
> > Thus, it is not needed to manually clear the device driver data to NULL.
> >
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
>
> it seems that we already have a patchset for this issue.
> please check https://patchwork.kernel.org/patch/2516651/
OK, I see.
These patches seem to be already submitted.
Thank you.
Best regards,
Jingoo Han
>
> thanks,
> rui
> > ---
> > drivers/thermal/armada_thermal.c | 1 -
> > 1 files changed, 0 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c
> > index 5b4d75f..0d02d4e 100644
> > --- a/drivers/thermal/armada_thermal.c
> > +++ b/drivers/thermal/armada_thermal.c
> > @@ -210,7 +210,6 @@ static int armada_thermal_exit(struct platform_device *pdev)
> > platform_get_drvdata(pdev);
> >
> > thermal_zone_device_unregister(armada_thermal);
> > - platform_set_drvdata(pdev, NULL);
> >
> > return 0;
> > }
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-07 0:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-06 4:26 [PATCH 1/6] thermal: armada: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-06 14:32 ` Zhang Rui
2013-05-07 0:09 ` Jingoo Han
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox