From: Jingoo Han <jg1.han@samsung.com>
To: 'Zhang Rui' <rui.zhang@intel.com>
Cc: 'Eduardo Valentin' <eduardo.valentin@ti.com>,
linux-pm@vger.kernel.org, Jingoo Han <jg1.han@samsung.com>,
'Kuninori Morimoto' <kuninori.morimoto.gx@renesas.com>
Subject: [PATCH 5/6] thermal: rcar: remove unnecessary platform_set_drvdata()
Date: Mon, 06 May 2013 13:30:58 +0900 [thread overview]
Message-ID: <004201ce4a12$816b9060$8442b120$@samsung.com> (raw)
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/thermal/rcar_thermal.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c
index 8d7edd4..63c7c13 100644
--- a/drivers/thermal/rcar_thermal.c
+++ b/drivers/thermal/rcar_thermal.c
@@ -487,8 +487,6 @@ static int rcar_thermal_remove(struct platform_device *pdev)
rcar_thermal_irq_disable(priv);
}
- platform_set_drvdata(pdev, NULL);
-
pm_runtime_put_sync(dev);
pm_runtime_disable(dev);
--
1.7.2.5
next reply other threads:[~2013-05-06 4:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-06 4:30 Jingoo Han [this message]
2013-05-07 0:37 ` [PATCH 5/6] thermal: rcar: remove unnecessary platform_set_drvdata() Kuninori Morimoto
2013-05-07 1:36 ` Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='004201ce4a12$816b9060$8442b120$@samsung.com' \
--to=jg1.han@samsung.com \
--cc=eduardo.valentin@ti.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox