* [PATCH 6/6] thermal: spear: remove unnecessary platform_set_drvdata()
@ 2013-05-06 4:34 Jingoo Han
2013-05-12 15:05 ` Viresh Kumar
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-05-06 4:34 UTC (permalink / raw)
To: 'Zhang Rui'
Cc: 'Eduardo Valentin', linux-pm, Jingoo Han,
'Vincenzo Frascino', 'Viresh Kumar'
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/thermal/spear_thermal.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/thermal/spear_thermal.c b/drivers/thermal/spear_thermal.c
index 3c5ee56..1a14eaa 100644
--- a/drivers/thermal/spear_thermal.c
+++ b/drivers/thermal/spear_thermal.c
@@ -174,7 +174,6 @@ static int spear_thermal_exit(struct platform_device *pdev)
struct spear_thermal_dev *stdev = spear_thermal->devdata;
thermal_zone_device_unregister(spear_thermal);
- platform_set_drvdata(pdev, NULL);
/* Disable SPEAr Thermal Sensor */
actual_mask = readl_relaxed(stdev->thermal_base);
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 6/6] thermal: spear: remove unnecessary platform_set_drvdata()
2013-05-06 4:34 [PATCH 6/6] thermal: spear: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-12 15:05 ` Viresh Kumar
0 siblings, 0 replies; 2+ messages in thread
From: Viresh Kumar @ 2013-05-12 15:05 UTC (permalink / raw)
To: Jingoo Han; +Cc: Zhang Rui, Eduardo Valentin, linux-pm, Vincenzo Frascino
On Mon, May 6, 2013 at 10:04 AM, Jingoo Han <jg1.han@samsung.com> wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/thermal/spear_thermal.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/thermal/spear_thermal.c b/drivers/thermal/spear_thermal.c
> index 3c5ee56..1a14eaa 100644
> --- a/drivers/thermal/spear_thermal.c
> +++ b/drivers/thermal/spear_thermal.c
> @@ -174,7 +174,6 @@ static int spear_thermal_exit(struct platform_device *pdev)
> struct spear_thermal_dev *stdev = spear_thermal->devdata;
>
> thermal_zone_device_unregister(spear_thermal);
> - platform_set_drvdata(pdev, NULL);
>
> /* Disable SPEAr Thermal Sensor */
> actual_mask = readl_relaxed(stdev->thermal_base);
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-12 15:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-06 4:34 [PATCH 6/6] thermal: spear: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-12 15:05 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox