linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: 최찬우 <cw00.choi@samsung.com>
To: rjw@sisk.pl
Cc: linux-pm@lists.linux-foundation.org, myungjoo.ham@samsung.com,
	kyungmin.park@samsung.com, m.szyprowski@samsung.com
Subject: [RFC PATCH] PM / Domains: Allow devices to generic pm domain regardless of power domain state
Date: Fri, 11 Nov 2011 13:49:21 +0900	[thread overview]
Message-ID: <004801cca02d$474c0a80$d5e41f80$%choi@samsung.com> (raw)

This patch allow devices to generic pm domain without reference
to the state of pm domains.

Generic PM domain framework can add devices to pm domain with GPD_STATE_ACTIVE
state.

If I don't want to enable the specific pm domain during kernel boot for power
saving,
so I can't add device to specific pm domain. Usually, the works ,which
initialize pm domain
and add device to pm domain, is operated during early kernel boot.

I think that we allow device to pm domain regardless of the state of pm domain
and
pm domain have to be enabled when devices included in pm domain executes
probe() or runtime pm.

Please let me know reason that why should we enable the pm domain when add
devices to it?

Best regards,
Chanwoo Choi

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Singed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Singed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
 drivers/base/power/domain.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index 6790cf7..3ee34ad 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -1093,11 +1093,6 @@ int pm_genpd_add_device(struct generic_pm_domain *genpd,
struct device *dev)
 
 	genpd_acquire_lock(genpd);
 
-	if (genpd->status == GPD_STATE_POWER_OFF) {
-		ret = -EINVAL;
-		goto out;
-	}
-
 	if (genpd->prepared_count > 0) {
 		ret = -EAGAIN;
 		goto out;
-- 
1.7.0.4

                 reply	other threads:[~2011-11-11  4:49 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='004801cca02d$474c0a80$d5e41f80$%choi@samsung.com' \
    --to=cw00.choi@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=m.szyprowski@samsung.com \
    --cc=myungjoo.ham@samsung.com \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).