From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Anand Moon <linux.amoon@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Linux PM list <linux-pm@vger.kernel.org>,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv2 6/6] thermal: exynos: Add runtime power management for tmu
Date: Wed, 18 May 2022 09:19:32 +0200 [thread overview]
Message-ID: <018b97c2-efab-699d-653d-c220a98f5ec3@linaro.org> (raw)
In-Reply-To: <CANAwSgSY=4zOLjw22GN+a7cc5j=myWWkD7gEQ4_3sgEaTS74Rw@mail.gmail.com>
On 17/05/2022 20:45, Anand Moon wrote:
> Hi Krzysztof,
>
> On Sun, 15 May 2022 at 15:18, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 15/05/2022 08:41, Anand Moon wrote:
>>> Add runtime power management for exynos thermal driver.
>>
>> First of all - why? Second, I do not see it being added. Where are the
>> runtime callbacks?
>>
>
> To control runtime control PMU, did I miss something?
Controlling runtime PM by itself is not a goal. What does it change if
it is enabled?
> I looked into imx thermal driver # drivers/thermal/imx_thermal.c
> to enable run-time power management for exynos driver.
So you have runtime PM enabled and then what happens? Where is the power
saving? Since you did not implement the callbacks, all this should be
explained in commit msg.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-05-18 7:19 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-15 6:41 [PATCHv2 0/6] Exynos Thermal code inprovement Anand Moon
2022-05-15 6:41 ` [PATCHv2 1/6] thermal: exynos: Enable core tmu hardware clk flag on exynos platform Anand Moon
2022-05-15 9:39 ` Krzysztof Kozlowski
2022-05-15 9:52 ` Krzysztof Kozlowski
2022-05-17 18:42 ` Anand Moon
2022-05-18 7:25 ` Krzysztof Kozlowski
2022-05-21 9:50 ` Anand Moon
2022-05-21 14:15 ` Krzysztof Kozlowski
2022-05-15 6:41 ` [PATCHv2 2/6] thermal: exynos: Reorder the gpu clock initialization for exynos5420 SoC Anand Moon
2022-05-15 9:41 ` Krzysztof Kozlowski
2022-05-17 18:43 ` Anand Moon
2022-05-18 7:28 ` Krzysztof Kozlowski
2022-05-21 9:51 ` Anand Moon
2022-05-21 14:20 ` Krzysztof Kozlowski
2022-05-15 9:50 ` Krzysztof Kozlowski
2022-05-17 18:43 ` Anand Moon
2022-05-15 6:41 ` [PATCHv2 3/6] thermal: exynos: Check before clk_disable_unprepare() not needed Anand Moon
2022-05-15 9:43 ` Krzysztof Kozlowski
2022-05-17 18:44 ` Anand Moon
2022-05-15 6:41 ` [PATCHv2 4/6] thermal: exynos: fixed the efuse min/max value for exynos5422 Anand Moon
2022-05-15 9:45 ` Krzysztof Kozlowski
2022-05-16 10:42 ` kernel test robot
2022-05-16 10:44 ` Krzysztof Kozlowski
2022-05-17 18:44 ` Anand Moon
2022-05-15 6:41 ` [PATCHv2 5/6] thermal: exynos: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr() Anand Moon
2022-05-15 9:47 ` Krzysztof Kozlowski
2022-05-17 18:44 ` Anand Moon
2022-05-15 6:41 ` [PATCHv2 6/6] thermal: exynos: Add runtime power management for tmu Anand Moon
2022-05-15 9:48 ` Krzysztof Kozlowski
2022-05-17 18:45 ` Anand Moon
2022-05-18 7:19 ` Krzysztof Kozlowski [this message]
2022-05-21 9:52 ` Anand Moon
2022-05-21 14:11 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=018b97c2-efab-699d-653d-c220a98f5ec3@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=amitk@kernel.org \
--cc=bzolnier@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).