From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74612C433F5 for ; Wed, 18 May 2022 07:19:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232058AbiERHTi (ORCPT ); Wed, 18 May 2022 03:19:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232056AbiERHTh (ORCPT ); Wed, 18 May 2022 03:19:37 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4EF957990 for ; Wed, 18 May 2022 00:19:35 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id w14so1989944lfl.13 for ; Wed, 18 May 2022 00:19:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=uE38ie4dSRzW9FDj6U1cSKtlpjyoAmfqSD8WeGqIZ6w=; b=V4tVnXW4I9FGwv3pHQXWH7Sx8fdLQJwrMstJPHl9bZRUUYOg2pcGBpvWAR+dvhZaUJ dqmWA2BlaNO3fm+y75NRnNuQyxlnntvgL1ujn80JTsUEXmH+5rBDJ/4GlLB0JtH9XvUA kPCVtHBTX9rsDDOu4JfQ2Y/gMoBwvuYRwVYcHxO4ZnW1LabVY7w9weZE/IAE1bfyH3Ea qNS0Bs1SqwJfcCWeEuf0HDdyAM+WdyWOEjb6g4y1S/LJkRh24jBpAtnRleUXIjQ7ftq6 iNrbhJD3wgUAD8gLTWCFvF12RdQeYlc3uGh1Y3wex7Zj7s79ZZU2FZFFn+Z3l5bGtRkS VR7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=uE38ie4dSRzW9FDj6U1cSKtlpjyoAmfqSD8WeGqIZ6w=; b=ojrwQvDFl5wnGCPxMpnjyh6OR07nfl+n6hW5lKSHXcBjGUpxHwSIARQedbCfriDUkp XhyuCgGEVe0EeFr7YtcLGDqM2bAfFg5s0r1Hfh20QYdQdYqOA56SI50P7pGNxWxdblJU zJ38qxTZK/RiH0vaioFbP4bXq2ZuEcsWRSCw/2JrXdbOiixP0kbEDKWDlF4BtHIIoPTO /50UbQmsnjup9MW3IKCGeOcyFVcvwiQUONSIC5vK4G137WMUegIfCFu4Tg/qemkUKVsm F+D9JrJ3F1EXqSqFcGVHeQAcBw2LppCrUyybT8Czshzm2YdnnwRc3sVlvd+c1zsNROF7 JVrg== X-Gm-Message-State: AOAM5328mQDAkPTUt8uHlxuwA2vBUF7eSasnqdnITq1FXHTCR/nShQ6q +g8/Cf2fXFQ+ddwPCHk22QjxszbgZDAhnXkI X-Google-Smtp-Source: ABdhPJzvx8mjcJx30Zvd3j2WPSo0iXGfy8QxdtkLmD+nJl8zb+xMYGpxRy5mCBgHUmVpkdiN9sT7QA== X-Received: by 2002:a05:6512:3183:b0:473:dffc:18ac with SMTP id i3-20020a056512318300b00473dffc18acmr18907162lfe.217.1652858374048; Wed, 18 May 2022 00:19:34 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id h21-20020ac250d5000000b00477b7264806sm125962lfm.9.2022.05.18.00.19.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 May 2022 00:19:33 -0700 (PDT) Message-ID: <018b97c2-efab-699d-653d-c220a98f5ec3@linaro.org> Date: Wed, 18 May 2022 09:19:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCHv2 6/6] thermal: exynos: Add runtime power management for tmu Content-Language: en-US To: Anand Moon , Krzysztof Kozlowski Cc: Bartlomiej Zolnierkiewicz , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Alim Akhtar , Linux PM list , linux-samsung-soc@vger.kernel.org, linux-arm-kernel , Linux Kernel References: <20220515064126.1424-1-linux.amoon@gmail.com> <20220515064126.1424-7-linux.amoon@gmail.com> <79b727f8-0631-5a96-fbc6-6e5d637bab7d@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 17/05/2022 20:45, Anand Moon wrote: > Hi Krzysztof, > > On Sun, 15 May 2022 at 15:18, Krzysztof Kozlowski > wrote: >> >> On 15/05/2022 08:41, Anand Moon wrote: >>> Add runtime power management for exynos thermal driver. >> >> First of all - why? Second, I do not see it being added. Where are the >> runtime callbacks? >> > > To control runtime control PMU, did I miss something? Controlling runtime PM by itself is not a goal. What does it change if it is enabled? > I looked into imx thermal driver # drivers/thermal/imx_thermal.c > to enable run-time power management for exynos driver. So you have runtime PM enabled and then what happens? Where is the power saving? Since you did not implement the callbacks, all this should be explained in commit msg. Best regards, Krzysztof