* [PATCH 1/3] thermal: rcar: remove unnecessary OOM messages
@ 2014-05-07 6:03 Jingoo Han
2014-05-07 6:04 ` [PATCH 2/3] thermal: exynos: " Jingoo Han
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Jingoo Han @ 2014-05-07 6:03 UTC (permalink / raw)
To: 'Zhang Rui'
Cc: 'Eduardo Valentin', linux-pm, 'Jingoo Han',
'Kuninori Morimoto', 'Simon Horman'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/thermal/rcar_thermal.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c
index 5a37940..105ab5e 100644
--- a/drivers/thermal/rcar_thermal.c
+++ b/drivers/thermal/rcar_thermal.c
@@ -374,10 +374,8 @@ static int rcar_thermal_probe(struct platform_device *pdev)
int idle = IDLE_INTERVAL;
common = devm_kzalloc(dev, sizeof(*common), GFP_KERNEL);
- if (!common) {
- dev_err(dev, "Could not allocate common\n");
+ if (!common)
return -ENOMEM;
- }
INIT_LIST_HEAD(&common->head);
spin_lock_init(&common->lock);
@@ -423,7 +421,6 @@ static int rcar_thermal_probe(struct platform_device *pdev)
priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
if (!priv) {
- dev_err(dev, "Could not allocate priv\n");
ret = -ENOMEM;
goto error_unregister;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/3] thermal: exynos: remove unnecessary OOM messages
2014-05-07 6:03 [PATCH 1/3] thermal: rcar: remove unnecessary OOM messages Jingoo Han
@ 2014-05-07 6:04 ` Jingoo Han
2014-05-07 6:05 ` [PATCH 3/3] thermal: spear: " Jingoo Han
2014-05-11 0:49 ` [PATCH 1/3] thermal: rcar: " Simon Horman
2 siblings, 0 replies; 5+ messages in thread
From: Jingoo Han @ 2014-05-07 6:04 UTC (permalink / raw)
To: 'Zhang Rui'
Cc: 'Eduardo Valentin', linux-pm, 'Jingoo Han',
'Amit Daniel Kachhap'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/thermal/samsung/exynos_tmu.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
index 0d96a51..9d17086 100644
--- a/drivers/thermal/samsung/exynos_tmu.c
+++ b/drivers/thermal/samsung/exynos_tmu.c
@@ -607,10 +607,8 @@ static int exynos_tmu_probe(struct platform_device *pdev)
data = devm_kzalloc(&pdev->dev, sizeof(struct exynos_tmu_data),
GFP_KERNEL);
- if (!data) {
- dev_err(&pdev->dev, "Failed to allocate driver structure\n");
+ if (!data)
return -ENOMEM;
- }
platform_set_drvdata(pdev, data);
mutex_init(&data->lock);
@@ -656,7 +654,6 @@ static int exynos_tmu_probe(struct platform_device *pdev)
sensor_conf = devm_kzalloc(&pdev->dev,
sizeof(struct thermal_sensor_conf), GFP_KERNEL);
if (!sensor_conf) {
- dev_err(&pdev->dev, "Failed to allocate registration struct\n");
ret = -ENOMEM;
goto err_clk;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 3/3] thermal: spear: remove unnecessary OOM messages
2014-05-07 6:03 [PATCH 1/3] thermal: rcar: remove unnecessary OOM messages Jingoo Han
2014-05-07 6:04 ` [PATCH 2/3] thermal: exynos: " Jingoo Han
@ 2014-05-07 6:05 ` Jingoo Han
2014-05-07 6:06 ` Viresh Kumar
2014-05-11 0:49 ` [PATCH 1/3] thermal: rcar: " Simon Horman
2 siblings, 1 reply; 5+ messages in thread
From: Jingoo Han @ 2014-05-07 6:05 UTC (permalink / raw)
To: 'Zhang Rui'
Cc: 'Eduardo Valentin', linux-pm, 'Jingoo Han',
'Viresh Kumar'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/thermal/spear_thermal.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/thermal/spear_thermal.c b/drivers/thermal/spear_thermal.c
index ab79ea4..1e2193f 100644
--- a/drivers/thermal/spear_thermal.c
+++ b/drivers/thermal/spear_thermal.c
@@ -113,10 +113,8 @@ static int spear_thermal_probe(struct platform_device *pdev)
}
stdev = devm_kzalloc(&pdev->dev, sizeof(*stdev), GFP_KERNEL);
- if (!stdev) {
- dev_err(&pdev->dev, "kzalloc fail\n");
+ if (!stdev)
return -ENOMEM;
- }
/* Enable thermal sensor */
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 3/3] thermal: spear: remove unnecessary OOM messages
2014-05-07 6:05 ` [PATCH 3/3] thermal: spear: " Jingoo Han
@ 2014-05-07 6:06 ` Viresh Kumar
0 siblings, 0 replies; 5+ messages in thread
From: Viresh Kumar @ 2014-05-07 6:06 UTC (permalink / raw)
To: Jingoo Han; +Cc: Zhang Rui, Eduardo Valentin, linux-pm@vger.kernel.org
On 7 May 2014 11:35, Jingoo Han <jg1.han@samsung.com> wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/thermal/spear_thermal.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/3] thermal: rcar: remove unnecessary OOM messages
2014-05-07 6:03 [PATCH 1/3] thermal: rcar: remove unnecessary OOM messages Jingoo Han
2014-05-07 6:04 ` [PATCH 2/3] thermal: exynos: " Jingoo Han
2014-05-07 6:05 ` [PATCH 3/3] thermal: spear: " Jingoo Han
@ 2014-05-11 0:49 ` Simon Horman
2 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2014-05-11 0:49 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Zhang Rui', 'Eduardo Valentin', linux-pm,
'Kuninori Morimoto'
On Wed, May 07, 2014 at 03:03:25PM +0900, Jingoo Han wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> drivers/thermal/rcar_thermal.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c
> index 5a37940..105ab5e 100644
> --- a/drivers/thermal/rcar_thermal.c
> +++ b/drivers/thermal/rcar_thermal.c
> @@ -374,10 +374,8 @@ static int rcar_thermal_probe(struct platform_device *pdev)
> int idle = IDLE_INTERVAL;
>
> common = devm_kzalloc(dev, sizeof(*common), GFP_KERNEL);
> - if (!common) {
> - dev_err(dev, "Could not allocate common\n");
> + if (!common)
> return -ENOMEM;
> - }
>
> INIT_LIST_HEAD(&common->head);
> spin_lock_init(&common->lock);
> @@ -423,7 +421,6 @@ static int rcar_thermal_probe(struct platform_device *pdev)
>
> priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> if (!priv) {
> - dev_err(dev, "Could not allocate priv\n");
> ret = -ENOMEM;
> goto error_unregister;
> }
> --
> 1.7.10.4
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-05-11 8:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-07 6:03 [PATCH 1/3] thermal: rcar: remove unnecessary OOM messages Jingoo Han
2014-05-07 6:04 ` [PATCH 2/3] thermal: exynos: " Jingoo Han
2014-05-07 6:05 ` [PATCH 3/3] thermal: spear: " Jingoo Han
2014-05-07 6:06 ` Viresh Kumar
2014-05-11 0:49 ` [PATCH 1/3] thermal: rcar: " Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).