From: "Christian König" <christian.koenig@amd.com>
To: Samuel Zhang <guoqing.zhang@amd.com>,
alexander.deucher@amd.com, rafael@kernel.org,
len.brown@intel.com, pavel@kernel.org,
gregkh@linuxfoundation.org, dakr@kernel.org, airlied@gmail.com,
simona@ffwll.ch, ray.huang@amd.com, matthew.auld@intel.com,
matthew.brost@intel.com, maarten.lankhorst@linux.intel.com,
mripard@kernel.org, tzimmermann@suse.de
Cc: mario.limonciello@amd.com, lijo.lazar@amd.com,
victor.zhao@amd.com, haijun.chang@amd.com, Qing.Ma@amd.com,
Owen.Zhang2@amd.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 2/5] drm/amdgpu: move GTT to shmem after eviction for hibernation
Date: Tue, 8 Jul 2025 10:41:48 +0200 [thread overview]
Message-ID: <02a0608a-d0cc-4cc7-9a99-a29dc006fd72@amd.com> (raw)
In-Reply-To: <20250708074248.1674924-3-guoqing.zhang@amd.com>
On 08.07.25 09:42, Samuel Zhang wrote:
> When hibernate with data center dGPUs, huge number of VRAM BOs evicted
> to GTT and takes too much system memory. This will cause hibernation
> fail due to insufficient memory for creating the hibernation image.
>
> Move GTT BOs to shmem in KMD, then shmem to swap disk in kernel
> hibernation code to make room for hibernation image.
>
> Signed-off-by: Samuel Zhang <guoqing.zhang@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 684d66bc0b5f..2f977fece08f 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -5021,8 +5021,16 @@ static int amdgpu_device_evict_resources(struct amdgpu_device *adev)
> return 0;
>
> ret = amdgpu_ttm_evict_resources(adev, TTM_PL_VRAM);
> - if (ret)
> + if (ret) {
> dev_warn(adev->dev, "evicting device resources failed\n");
> + return ret;
> + }
> +
> + if (adev->in_s4) {
> + ret = ttm_device_prepare_hibernation(&adev->mman.bdev);
> + if (ret)
> + dev_err(adev->dev, "prepare hibernation failed, %d\n", ret);
> + }
> return ret;
> }
>
next prev parent reply other threads:[~2025-07-08 8:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-08 7:42 [PATCH v3 0/5] reduce system memory requirement for hibernation Samuel Zhang
2025-07-08 7:42 ` [PATCH v3 1/5] drm/ttm: add new api ttm_device_prepare_hibernation() Samuel Zhang
2025-07-08 8:38 ` Christian König
2025-07-08 7:42 ` [PATCH v3 2/5] drm/amdgpu: move GTT to shmem after eviction for hibernation Samuel Zhang
2025-07-08 8:41 ` Christian König [this message]
2025-07-08 7:42 ` [PATCH v3 3/5] PM: hibernate: shrink shmem pages after dev_pm_ops.prepare() Samuel Zhang
2025-07-08 14:28 ` Mario Limonciello
2025-07-08 14:33 ` Rafael J. Wysocki
2025-07-08 7:42 ` [PATCH v3 4/5] PM: hibernate: add new api pm_transition_event() Samuel Zhang
2025-07-08 14:36 ` Mario Limonciello
2025-07-08 14:39 ` Rafael J. Wysocki
2025-07-08 16:07 ` Zhang, GuoQing (Sam)
2025-07-08 16:11 ` Mario Limonciello
2025-07-08 7:42 ` [PATCH v3 5/5] drm/amdgpu: do not resume device in thaw for normal hibernation Samuel Zhang
2025-07-08 10:28 ` Lazar, Lijo
2025-07-08 14:40 ` Mario Limonciello
2025-07-08 16:08 ` Zhang, GuoQing (Sam)
2025-07-08 16:11 ` Mario Limonciello
2025-07-08 14:31 ` [PATCH v3 0/5] reduce system memory requirement for hibernation Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02a0608a-d0cc-4cc7-9a99-a29dc006fd72@amd.com \
--to=christian.koenig@amd.com \
--cc=Owen.Zhang2@amd.com \
--cc=Qing.Ma@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=guoqing.zhang@amd.com \
--cc=haijun.chang@amd.com \
--cc=len.brown@intel.com \
--cc=lijo.lazar@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mario.limonciello@amd.com \
--cc=matthew.auld@intel.com \
--cc=matthew.brost@intel.com \
--cc=mripard@kernel.org \
--cc=pavel@kernel.org \
--cc=rafael@kernel.org \
--cc=ray.huang@amd.com \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=victor.zhao@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox