From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E31B3346B2 for ; Mon, 17 Nov 2025 12:45:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763383545; cv=none; b=nKtzRApJXf1vRrNlxfF0/bBbh6a8siSZFxrtfkQ3EH24IKpSRHyGDjiW8hUFZ2rD6qWRf3zZPX0T8so+Z0OS3XXL15WXAZoPGSkzFUaOXsJDNG/vtfBhEpvnOJiLjIQa88vZ0gWGl/cqtt0ZUWEXfscJhq0U9bH4pBUXrQDiyyg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763383545; c=relaxed/simple; bh=zAaBRN8aUVkBoo2Ai+HPbmL2d7bftI05RskM7Mnrp0c=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=b6SAG/u9Keli1nVL2acroFVhvTKT2bbC2J8yofs745eOUhwJCjkYFA2V9r7tUY7qFQptzYe6qYND7FqcOj8ydsQ3U1wl4vsETnag2YTpjfl2yp7w6icZsCbzxqgcKGJ5vjveJWVLbZ03de7HnuQj+An+YpFwyB5SsVUHA+6s8hQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=L3B36CcR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=e3gXn1TT; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="L3B36CcR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="e3gXn1TT" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AHAkM9E2790796 for ; Mon, 17 Nov 2025 12:45:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MuLTRWfP/NWeif4W5Wukk0z+JStEEIR4r6n4oQu+nMA=; b=L3B36CcRF/f/R6CT LMAM/9iI3xTMjhFkBBC6EmFEixqBQ3DsXTeo1M4xZFkow6RPcaroP7cHXzvUPAde y+fOW4P6RBWLnoVFxlj+JgVmydKgcmB3eLKHJ+dcnDbWuSeG3CxUTTPFWGyDdFbv 6f+BTdLbDbtIArinalfHoJntQ6k5ZyTy9omO3uN5G5oDtiD2B5zOOqWCi2Aw13YO VCPaJ8wFZK1irkPqDCVoBkBdL2NuRwAmo0THt4mJQWsjNp8R4bpckQ4/hD39Q5p/ w3PgpSqrmDR8wePJb6QYGW7FmK4h/kzymenCyl/k2f0GWQ3CfIRit0zIUOqFiVSj bSUEFQ== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4afu5bhmag-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 17 Nov 2025 12:45:43 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4ee23b6b6fdso3269111cf.0 for ; Mon, 17 Nov 2025 04:45:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763383543; x=1763988343; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=MuLTRWfP/NWeif4W5Wukk0z+JStEEIR4r6n4oQu+nMA=; b=e3gXn1TTT35IyX3f8CchP5Qd9EKERKLYkqs2clFr1DqzNZPs1xSQuD6CSMHUo0ZXv5 o2lnjUSXt3Mfk3Pxxi+Wnd4k/vnE5AgCwt14CCUzt/0FuQH3/EsUoGiA4HuFUaRP9IZv tG3CTWDn87EIc2ng+MHl3lPG5O5OyCEuMsLV+T0igEnKnKrO5dhlx8YFt4vEs30u9XDg 192HRGvMRteDvHUSngtyiXKC4oHkyI4tsfIiHGbEeCFuqdBZu8af3Iz5egxX7aJNviCP thUfH2hNTxpES5u2n+8hSL6GlHnIT7DcVXlHg5sxSRsC9Xbkl98+Oha7xIfB9EjmscAv lxmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763383543; x=1763988343; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MuLTRWfP/NWeif4W5Wukk0z+JStEEIR4r6n4oQu+nMA=; b=hdzZvnWNNfa8q8aXm1mCHzV1HpgBZwRc3kSkfK1a2kEdYUAwXNm/+ug92OGdvearVv pS3Eg/mXg1HcdaXUXEYTeWLrRfaTpvLFu9tD1TVQqBzXAhJdLtiZg9qioVMXYbFv+PTh 7HQ5nklWHpz+mL4k1DzIpmE97byZelvyjsHvtYBypscPuiPDWv86HnKSZQ6UNp1+Mh3a CnsPOMtIlfICEskj+R5pPgcR7QfV8M0Mvd0ASoYXQ3RLWOco9cXrn5AFWddMVrZicoNn QKbtdFifNqc5lOdHLjNwBAz9FQN+ggmY/F5i7VGvm6bTvu6MhkoS7qmD6hGI24U+M0Vw 7Hpg== X-Forwarded-Encrypted: i=1; AJvYcCVidkxtOf7grCtUOZXGXTgSkEPVmV1UStpHxQt/Z7aR2hHQCUa5hC69JpbCf5vhmWJtPYcSSmOK5w==@vger.kernel.org X-Gm-Message-State: AOJu0Yz15J8SvL70t13AtwcibI77BRlnc3CIr4aprrlVNTBrHS7ZNQNg 7JCiZH6AjjdSnPNCi9iagpumX4huGqHhDlnXaqyx4hkcPtq3+Fxiw+k/5B2uOsPpZbhC134lW32 aBAsMHmSke03p/l/xXzidzbjS0YPSCqi1qB8Xv/uX0fFNGZVsIUlA2J3THach8g== X-Gm-Gg: ASbGncvX6s/lU3eV3LWwlGj43Mz4GtvjgrRNcXcFFFsK4UqYywLFlmGRU3kzfmpXL4X gtBFT64uZEUxxd5P8oyHQ3WYTTFZcnQXRjmSJ1NxGpjO0GM7pDyKGURKmUnHvnRqZTYYQmR8mS8 P+fy8my5mgSF6qo3mchCdCml4u/nOZg+Lw5liIfSu+A0XXql5s3GfjlI1kiB9aCEVMiY/rK2I56 b+7zD02pLxo9MqdUy+XlS5HFTehQmBP0oNtTNF/+6a6qP7hWXYOpGT/HW7VEU2SFNSSfcMmstU6 VnrK6v6scwfahWG6IXm1c5+MnY+45jV5VHYTcjzK+P/idGN41+G/TT6TwWPPSDOfPsXtr7Mfh2o Ojd502fE2f5g2qbPlwOnkVWK2Ho2fmBJhjLXvkMzUh1DRoYYSnKF63xr6 X-Received: by 2002:ac8:7c45:0:b0:4ee:2638:ea2 with SMTP id d75a77b69052e-4ee26383190mr13677181cf.9.1763383542625; Mon, 17 Nov 2025 04:45:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IH1/SdgjmXEVX8GzC7p9XqxdwXaxPInFwyfN61ifnpwgnj8DKGAGgVzQsWm7YyJ+/G2u7dJRA== X-Received: by 2002:ac8:7c45:0:b0:4ee:2638:ea2 with SMTP id d75a77b69052e-4ee26383190mr13676931cf.9.1763383542098; Mon, 17 Nov 2025 04:45:42 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fd809absm1076620566b.44.2025.11.17.04.45.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Nov 2025 04:45:41 -0800 (PST) Message-ID: <02db51aa-6e19-411f-875f-718b8215c373@oss.qualcomm.com> Date: Mon, 17 Nov 2025 13:45:40 +0100 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] power: supply: qcom_battmgr: improve charge control threshold handling To: Fenglin Wu , Val Packett , Sebastian Reichel , Neil Armstrong , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251012233333.19144-2-val@packett.cool> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: fxMoUkZJpf8IY6e5EngUYAkodBcBvT04 X-Proofpoint-ORIG-GUID: fxMoUkZJpf8IY6e5EngUYAkodBcBvT04 X-Authority-Analysis: v=2.4 cv=Xvz3+FF9 c=1 sm=1 tr=0 ts=691b18f7 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Yb_LYS4cgvVAXpmhZQEA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTE3MDEwNyBTYWx0ZWRfX7nVlB9WKvbgW yroGwswnUdVuNr3wv2LFI50W4l9IWMWpneA7gNSYcd7UDY091cQkwjCFngRemhiVc+H2u5r/Zyh KbuAaVXf9x1xveu5gih7jasf9b9ZksF0nv/r66fkyv82aNybjSo3WAGhORCikvLnotfSQjD9vMK AqPydgGLGQ2q4SkPkZE1uWRnX/lfk/iO6MDfBz7rXA+xgswfw7PZf9aFPsboJFEu47HM3XHQXDb 7URDWQRkM4JaMGUr0aKqBObjwfBpFJQFuVzdBoRUFpJKvtiKeuqBgzVg6kL6rZDl2FhBmyYHu8c tcYnvghF39KAiO2G6IpogieiSKCyMRI5noexAiPTLMJ41/kt35jaJ8iitFAj45OneXHUedQfJ0+ qcs+WSX7xATvD7Wy0d9wnDg1rhPASA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-17_03,2025-11-13_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 phishscore=0 priorityscore=1501 clxscore=1015 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511170107 On 11/17/25 6:12 AM, Fenglin Wu wrote: > > On 10/13/2025 7:32 AM, Val Packett wrote: >> Currently, upowerd is unable to turn off the battery preservation mode[1] >> on Qualcomm laptops, because it does that by setting the start threshold to >> zero and the driver returns an error: >> >> pmic_glink.power-supply.0: charge control start threshold exceed range: [50 - 95] >> >> Kernel documentation says the end threshold must be clamped[2] but does >> not say anything about the start threshold. >> >> In this proposal I've special-cased start==0 to actually disable the >> functionality via the enable bit, and otherwise made both start and >> end thresholds be clamped to the acceptable range. Hopefully that's >> fine? > It is fine to clamping the threshold to the acceptable range. Thank you for making the changes. >> Or should the [1 - 49] range for start actually be rejected? > The minimum charging start threshold was set to 50 to improve user experience. If the threshold is too low and the system keeps drawing power from the battery frequently due to a large system load and a weak charger, the laptop will only begin charging when the battery level falls below that threshold. If the user disconnects the charger at that time, then the device would be only having a battery below 50%. Setting the threshold at 50 ensures the battery always stays above 50%. So can we set it lower? Such decisions are best deferred to userspace and/or the user, which can limit what the kernel exposes as necessary/deemed useful Konrad