Linux Power Management development
 help / color / mirror / Atom feed
From: Lukasz Luba <lukasz.luba@arm.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	Daniel Lezcano <daniel.lezcano@kernel.org>,
	Zhang Rui <rui.zhang@intel.com>
Subject: Re: [PATCH v1 1/1] thermal: sysfs: switch to use scnprintf() to suppress truncation warning
Date: Fri, 4 Sep 2026 09:01:35 +0100	[thread overview]
Message-ID: <03b270ab-4a39-4a82-b970-c0c10f400549@arm.com> (raw)
In-Reply-To: <20260817103324.1020212-1-andriy.shevchenko@linux.intel.com>



On 8/17/26 11:33, Andy Shevchenko wrote:
> Switch the sysfs code to use scnprintf() to avoid warnings about potential
> truncation of the names of the sysfs attributes. We can't increase the buffer
> size because the size is the part of an ABI for some reason. Note, with
> the current size of buffer the affected attributes have a room for up to
> 1000 names, which ought to be enough for all cases. There is no functional
> change, as the same limitation was implied before.

Right, it doesn't touch the real truncation check problem only avoids
the complain from the tool. We can think about this later in some
redesign.

> 
> Fixes: c56f5c0342df ("Thermal: Make Thermal trip points writeable")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>   drivers/thermal/thermal_sysfs.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)


Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>


  parent reply	other threads:[~2026-09-04  8:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-17 10:33 [PATCH v1 1/1] thermal: sysfs: switch to use scnprintf() to suppress truncation warning Andy Shevchenko
2026-09-03 11:41 ` Andy Shevchenko
2026-09-04  8:01 ` Lukasz Luba [this message]
2026-09-04 13:54   ` Rafael J. Wysocki (Intel)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=03b270ab-4a39-4a82-b970-c0c10f400549@arm.com \
    --to=lukasz.luba@arm.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=daniel.lezcano@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox