From: Adrian Hunter <adrian.hunter@intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci <linux-pci@vger.kernel.org>,
linux-pm <linux-pm@vger.kernel.org>,
linux-acpi <linux-acpi@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Lukas Wunner <lukas@wunner.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH] PCI: For d3_delay and d3cold_delay, zero means zero
Date: Tue, 14 Mar 2017 15:23:50 +0200 [thread overview]
Message-ID: <04a3c82b-7adb-adf4-52ed-3067413a2f4a@intel.com> (raw)
In-Reply-To: <1489497718-4099-1-git-send-email-adrian.hunter@intel.com>
Forgot to put this is V2, sorry. It has changes to the commit message as
requested.
On 14/03/17 15:21, Adrian Hunter wrote:
> msleep() still sleeps 1 jiffy even when told to sleep for zero
> milliseconds. That can end up being 1-2 milliseconds or more. In the cases
> of d3_delay and d3cold_delay, that unnecessarily increases suspend and/or
> resume latencies.
>
> So, do not sleep at all for the respective cases of d3_delay is zero or
> d3cold_delay is zero.
>
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/pci/pci.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 7904d02ffdb9..9779483f81fd 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -66,7 +66,8 @@ static void pci_dev_d3_sleep(struct pci_dev *dev)
> if (delay < pci_pm_d3_delay)
> delay = pci_pm_d3_delay;
>
> - msleep(delay);
> + if (delay)
> + msleep(delay);
> }
>
> #ifdef CONFIG_PCI_DOMAINS
> @@ -827,7 +828,8 @@ static void __pci_start_power_transition(struct pci_dev *dev, pci_power_t state)
> * because have already delayed for the bridge.
> */
> if (dev->runtime_d3cold) {
> - msleep(dev->d3cold_delay);
> + if (dev->d3cold_delay)
> + msleep(dev->d3cold_delay);
> /*
> * When powering on a bridge from D3cold, the
> * whole hierarchy may be powered on into
>
next prev parent reply other threads:[~2017-03-14 13:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 9:44 [PATCH] PCI: For d3_delay and d3cold_delay, zero means zero Adrian Hunter
2017-03-14 13:03 ` Bjorn Helgaas
2017-03-14 13:21 ` Adrian Hunter
2017-03-14 13:23 ` Adrian Hunter [this message]
2017-03-14 17:52 ` Rafael J. Wysocki
2017-03-14 20:04 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04a3c82b-7adb-adf4-52ed-3067413a2f4a@intel.com \
--to=adrian.hunter@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=helgaas@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).