From: Krzysztof Kozlowski <krzk@kernel.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Sebastian Reichel <sre@kernel.org>,
Rhyland Klein <rklein@nvidia.com>,
Anton Vorontsov <cbouatmailru@gmail.com>,
Jenny TC <jenny.tc@intel.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, regressions@lists.linux.dev
Subject: Re: [PATCH] power: supply: core: return -EAGAIN on uninitialized read temp
Date: Fri, 5 Jul 2024 07:56:22 +0200 [thread overview]
Message-ID: <0516a900-0911-47f3-888e-57d014986e3b@kernel.org> (raw)
In-Reply-To: <a50eb87a-4dcc-4272-b897-fb8170bfe58b@linaro.org>
On 04/07/2024 18:41, Daniel Lezcano wrote:
> On 04/07/2024 10:52, Neil Armstrong wrote:
>> If the thermal core tries to update the temperature from an
>> uninitialized power supply, it will swawn the following warning:
>> thermal thermal_zoneXX: failed to read out thermal zone (-19)
>>
>> But reading from an uninitialized power supply should not be
>> considered as a fatal error, but the thermal core expects
>> the -EAGAIN error to be returned in this particular case.
>>
>> So convert -ENODEV as -EAGAIN to express the fact that reading
>> temperature from an uninitialized power supply shouldn't be
>> a fatal error, but should indicate to the thermal zone it should
>> retry later.
>>
>> It notably removes such messages on Qualcomm platforms using the
>> qcom_battmgr driver spawning warnings until the aDSP firmware
>> gets up and the battery manager reports valid data.
>
> Is it possible to have the aDSP firmware ready first ?
I don't think so. ADSP firmware is a file, so as every firmware it can
be loaded from rootfs, not initramfs (unlike this driver), or even missing.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-05 5:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-04 8:52 [PATCH] power: supply: core: return -EAGAIN on uninitialized read temp Neil Armstrong
2024-07-04 9:12 ` Greg KH
2024-07-04 16:41 ` Daniel Lezcano
2024-07-05 5:56 ` Krzysztof Kozlowski [this message]
2024-07-05 8:08 ` Daniel Lezcano
2024-07-15 9:30 ` Neil Armstrong
2024-07-15 9:41 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0516a900-0911-47f3-888e-57d014986e3b@kernel.org \
--to=krzk@kernel.org \
--cc=cbouatmailru@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=jenny.tc@intel.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=regressions@lists.linux.dev \
--cc=rjw@rjwysocki.net \
--cc=rklein@nvidia.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox