* [PATCH -next] thermal: Fix unsigned comparison with less than zero
@ 2023-01-06 0:59 Yang Li
2023-01-06 7:03 ` Zhang, Rui
0 siblings, 1 reply; 3+ messages in thread
From: Yang Li @ 2023-01-06 0:59 UTC (permalink / raw)
To: rafael
Cc: daniel.lezcano, amitk, rui.zhang, linux-pm, linux-kernel, Yang Li,
Abaci Robot
The return value from the call to intel_tcc_get_tjmax() is int, which can
be a negative error code. However, the return value is being assigned to
an u32 variable 'tj_max', so making 'tj_max' an int.
Eliminate the following warning:
./drivers/thermal/intel/intel_soc_dts_iosf.c:394:5-11: WARNING: Unsigned expression compared with zero: tj_max < 0
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3637
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/thermal/intel/intel_soc_dts_iosf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/intel/intel_soc_dts_iosf.c b/drivers/thermal/intel/intel_soc_dts_iosf.c
index 2138693d8afd..8c26f7b2316b 100644
--- a/drivers/thermal/intel/intel_soc_dts_iosf.c
+++ b/drivers/thermal/intel/intel_soc_dts_iosf.c
@@ -380,7 +380,7 @@ struct intel_soc_dts_sensors *intel_soc_dts_iosf_init(
{
struct intel_soc_dts_sensors *sensors;
bool notification;
- u32 tj_max;
+ int tj_max;
int ret;
int i;
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] thermal: Fix unsigned comparison with less than zero
2023-01-06 0:59 [PATCH -next] thermal: Fix unsigned comparison with less than zero Yang Li
@ 2023-01-06 7:03 ` Zhang, Rui
2023-01-12 19:23 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Zhang, Rui @ 2023-01-06 7:03 UTC (permalink / raw)
To: yang.lee@linux.alibaba.com, rafael@kernel.org
Cc: linux-pm@vger.kernel.org, daniel.lezcano@linaro.org,
linux-kernel@vger.kernel.org, amitk@kernel.org,
abaci@linux.alibaba.com
On Fri, 2023-01-06 at 08:59 +0800, Yang Li wrote:
> The return value from the call to intel_tcc_get_tjmax() is int, which
> can
> be a negative error code. However, the return value is being assigned
> to
> an u32 variable 'tj_max', so making 'tj_max' an int.
>
> Eliminate the following warning:
> ./drivers/thermal/intel/intel_soc_dts_iosf.c:394:5-11: WARNING:
> Unsigned expression compared with zero: tj_max < 0
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3637
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Thanks for catching this issue.
Acked-by: Zhang Rui <rui.zhang@intel.com>
thanks,
rui
> ---
> drivers/thermal/intel/intel_soc_dts_iosf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/intel/intel_soc_dts_iosf.c
> b/drivers/thermal/intel/intel_soc_dts_iosf.c
> index 2138693d8afd..8c26f7b2316b 100644
> --- a/drivers/thermal/intel/intel_soc_dts_iosf.c
> +++ b/drivers/thermal/intel/intel_soc_dts_iosf.c
> @@ -380,7 +380,7 @@ struct intel_soc_dts_sensors
> *intel_soc_dts_iosf_init(
> {
> struct intel_soc_dts_sensors *sensors;
> bool notification;
> - u32 tj_max;
> + int tj_max;
> int ret;
> int i;
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] thermal: Fix unsigned comparison with less than zero
2023-01-06 7:03 ` Zhang, Rui
@ 2023-01-12 19:23 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2023-01-12 19:23 UTC (permalink / raw)
To: Zhang, Rui, yang.lee@linux.alibaba.com
Cc: rafael@kernel.org, linux-pm@vger.kernel.org,
daniel.lezcano@linaro.org, linux-kernel@vger.kernel.org,
amitk@kernel.org, abaci@linux.alibaba.com
On Fri, Jan 6, 2023 at 8:03 AM Zhang, Rui <rui.zhang@intel.com> wrote:
>
> On Fri, 2023-01-06 at 08:59 +0800, Yang Li wrote:
> > The return value from the call to intel_tcc_get_tjmax() is int, which
> > can
> > be a negative error code. However, the return value is being assigned
> > to
> > an u32 variable 'tj_max', so making 'tj_max' an int.
> >
> > Eliminate the following warning:
> > ./drivers/thermal/intel/intel_soc_dts_iosf.c:394:5-11: WARNING:
> > Unsigned expression compared with zero: tj_max < 0
> >
> > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3637
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
>
> Thanks for catching this issue.
>
> Acked-by: Zhang Rui <rui.zhang@intel.com>
Applied, thanks!
> > ---
> > drivers/thermal/intel/intel_soc_dts_iosf.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/thermal/intel/intel_soc_dts_iosf.c
> > b/drivers/thermal/intel/intel_soc_dts_iosf.c
> > index 2138693d8afd..8c26f7b2316b 100644
> > --- a/drivers/thermal/intel/intel_soc_dts_iosf.c
> > +++ b/drivers/thermal/intel/intel_soc_dts_iosf.c
> > @@ -380,7 +380,7 @@ struct intel_soc_dts_sensors
> > *intel_soc_dts_iosf_init(
> > {
> > struct intel_soc_dts_sensors *sensors;
> > bool notification;
> > - u32 tj_max;
> > + int tj_max;
> > int ret;
> > int i;
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-12 19:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-06 0:59 [PATCH -next] thermal: Fix unsigned comparison with less than zero Yang Li
2023-01-06 7:03 ` Zhang, Rui
2023-01-12 19:23 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).