* Re: [PATCH 0/2] thermal/drivers/mediatek: fix a regression affecting other subsystems [not found] <20230529162056.3786301-1-uwu@icenowy.me> @ 2023-06-13 8:44 ` Daniel Lezcano 2023-07-22 12:13 ` Icenowy Zheng 2024-05-17 9:50 ` Dan Carpenter 0 siblings, 2 replies; 4+ messages in thread From: Daniel Lezcano @ 2023-06-13 8:44 UTC (permalink / raw) To: Icenowy Zheng, Rafael J . Wysocki, Amit Kucheria, Zhang Rui, Matthias Brugger, AngeloGioacchino Del Regno, Kang Chen, Dongliang Mu Cc: linux-pm, linux-kernel, linux-arm-kernel, linux-mediatek On 29/05/2023 18:20, Icenowy Zheng wrote: > In the commit I reverted as the first commit of this patchset, the > of_iomap function call, which allows multiple mapping of the same > physical memory space, is replaced to calling devm_of_iomap, which > registers exclusivity, and on my system (mt8173-elm), preventing display > from working. > > So I reverted it, and to really solve the problem that the original > commit wants to solve, I read the source of auxadc-thermal and realized > that the address of these two memory blocks are not saved after probe, > and they're only used when initializing the thermal sensors. This leads > to my final fix, which is the second commit here, that adds of_iounmap > just to the probe function. > > Icenowy Zheng (2): > Revert "thermal/drivers/mediatek: Use devm_of_iomap to avoid resource > leak in mtk_thermal_probe" > thermal/drivers/mediatek: unmap foreign MMIO after probing > > drivers/thermal/mediatek/auxadc_thermal.c | 46 ++++++++++++----------- > 1 file changed, 24 insertions(+), 22 deletions(-) I'll apply only the revert and let you revisit the patch 2 which could be improved. -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 0/2] thermal/drivers/mediatek: fix a regression affecting other subsystems 2023-06-13 8:44 ` [PATCH 0/2] thermal/drivers/mediatek: fix a regression affecting other subsystems Daniel Lezcano @ 2023-07-22 12:13 ` Icenowy Zheng 2023-07-23 10:17 ` Daniel Lezcano 2024-05-17 9:50 ` Dan Carpenter 1 sibling, 1 reply; 4+ messages in thread From: Icenowy Zheng @ 2023-07-22 12:13 UTC (permalink / raw) To: Daniel Lezcano, Rafael J . Wysocki, Amit Kucheria, Zhang Rui, Matthias Brugger, AngeloGioacchino Del Regno, Kang Chen, Dongliang Mu Cc: linux-pm, linux-kernel, linux-arm-kernel, linux-mediatek 在 2023-06-13星期二的 10:44 +0200,Daniel Lezcano写道: > On 29/05/2023 18:20, Icenowy Zheng wrote: > > In the commit I reverted as the first commit of this patchset, the > > of_iomap function call, which allows multiple mapping of the same > > physical memory space, is replaced to calling devm_of_iomap, which > > registers exclusivity, and on my system (mt8173-elm), preventing > > display > > from working. > > > > So I reverted it, and to really solve the problem that the original > > commit wants to solve, I read the source of auxadc-thermal and > > realized > > that the address of these two memory blocks are not saved after > > probe, > > and they're only used when initializing the thermal sensors. This > > leads > > to my final fix, which is the second commit here, that adds > > of_iounmap > > just to the probe function. > > > > Icenowy Zheng (2): > > Revert "thermal/drivers/mediatek: Use devm_of_iomap to avoid > > resource > > leak in mtk_thermal_probe" > > thermal/drivers/mediatek: unmap foreign MMIO after probing > > > > drivers/thermal/mediatek/auxadc_thermal.c | 46 ++++++++++++------ > > ----- > > 1 file changed, 24 insertions(+), 22 deletions(-) > > I'll apply only the revert and let you revisit the patch 2 which > could > be improved. Sorry, is the first patch applied? I didn't see it in any kernel trees... I have no current idea about how to fix in patch 2. > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 0/2] thermal/drivers/mediatek: fix a regression affecting other subsystems 2023-07-22 12:13 ` Icenowy Zheng @ 2023-07-23 10:17 ` Daniel Lezcano 0 siblings, 0 replies; 4+ messages in thread From: Daniel Lezcano @ 2023-07-23 10:17 UTC (permalink / raw) To: Icenowy Zheng, Rafael J . Wysocki, Amit Kucheria, Zhang Rui, Matthias Brugger, AngeloGioacchino Del Regno, Kang Chen, Dongliang Mu Cc: linux-pm, linux-kernel, linux-arm-kernel, linux-mediatek On 22/07/2023 14:13, Icenowy Zheng wrote: > 在 2023-06-13星期二的 10:44 +0200,Daniel Lezcano写道: >> On 29/05/2023 18:20, Icenowy Zheng wrote: >>> In the commit I reverted as the first commit of this patchset, the >>> of_iomap function call, which allows multiple mapping of the same >>> physical memory space, is replaced to calling devm_of_iomap, which >>> registers exclusivity, and on my system (mt8173-elm), preventing >>> display >>> from working. >>> >>> So I reverted it, and to really solve the problem that the original >>> commit wants to solve, I read the source of auxadc-thermal and >>> realized >>> that the address of these two memory blocks are not saved after >>> probe, >>> and they're only used when initializing the thermal sensors. This >>> leads >>> to my final fix, which is the second commit here, that adds >>> of_iounmap >>> just to the probe function. >>> >>> Icenowy Zheng (2): >>> Revert "thermal/drivers/mediatek: Use devm_of_iomap to avoid >>> resource >>> leak in mtk_thermal_probe" >>> thermal/drivers/mediatek: unmap foreign MMIO after probing >>> >>> drivers/thermal/mediatek/auxadc_thermal.c | 46 ++++++++++++------ >>> ----- >>> 1 file changed, 24 insertions(+), 22 deletions(-) >> >> I'll apply only the revert and let you revisit the patch 2 which >> could >> be improved. > > Sorry, is the first patch applied? I didn't see it in any kernel > trees... Yes, sorry, I got another patch meanwhile which provided the same revert with more tags https://lore.kernel.org/r/20230525121811.3360268-1-ricardo.canuelo@collabora.com -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 0/2] thermal/drivers/mediatek: fix a regression affecting other subsystems 2023-06-13 8:44 ` [PATCH 0/2] thermal/drivers/mediatek: fix a regression affecting other subsystems Daniel Lezcano 2023-07-22 12:13 ` Icenowy Zheng @ 2024-05-17 9:50 ` Dan Carpenter 1 sibling, 0 replies; 4+ messages in thread From: Dan Carpenter @ 2024-05-17 9:50 UTC (permalink / raw) To: Daniel Lezcano Cc: Icenowy Zheng, Rafael J . Wysocki, Amit Kucheria, Zhang Rui, Matthias Brugger, AngeloGioacchino Del Regno, Kang Chen, Dongliang Mu, linux-pm, linux-kernel, linux-arm-kernel, linux-mediatek On Tue, Jun 13, 2023 at 10:44:51AM +0200, Daniel Lezcano wrote: > On 29/05/2023 18:20, Icenowy Zheng wrote: > > In the commit I reverted as the first commit of this patchset, the > > of_iomap function call, which allows multiple mapping of the same > > physical memory space, is replaced to calling devm_of_iomap, which > > registers exclusivity, and on my system (mt8173-elm), preventing display > > from working. > > > > So I reverted it, and to really solve the problem that the original > > commit wants to solve, I read the source of auxadc-thermal and realized > > that the address of these two memory blocks are not saved after probe, > > and they're only used when initializing the thermal sensors. This leads > > to my final fix, which is the second commit here, that adds of_iounmap > > just to the probe function. > > > > Icenowy Zheng (2): > > Revert "thermal/drivers/mediatek: Use devm_of_iomap to avoid resource > > leak in mtk_thermal_probe" > > thermal/drivers/mediatek: unmap foreign MMIO after probing > > > > drivers/thermal/mediatek/auxadc_thermal.c | 46 ++++++++++++----------- > > 1 file changed, 24 insertions(+), 22 deletions(-) > > I'll apply only the revert and let you revisit the patch 2 which could be > improved. What's the issue with patch 2/2? It looks okay to me. regards, dan carpenter ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-05-17 9:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230529162056.3786301-1-uwu@icenowy.me>
2023-06-13 8:44 ` [PATCH 0/2] thermal/drivers/mediatek: fix a regression affecting other subsystems Daniel Lezcano
2023-07-22 12:13 ` Icenowy Zheng
2023-07-23 10:17 ` Daniel Lezcano
2024-05-17 9:50 ` Dan Carpenter
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).