From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev, Zaid Alali <zaidal@os.amperecomputing.com>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
linux-acpi@vger.kernel.org, devel@acpica.org,
linux-pm@vger.kernel.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Ira Weiny <ira.weiny@intel.com>
Subject: [rafael-pm:bleeding-edge 135/136] drivers/acpi/apei/einj-core.c:769 einj_probe() warn: missing unwind goto?
Date: Tue, 13 May 2025 17:35:24 +0300 [thread overview]
Message-ID: <0899a8f6-5880-49dc-b699-e369719280e1@suswa.mountain> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge
head: 9148437b5790361af63c5ffb89112c380fda2472
commit: e54b1dc1c4f083cb66a70d8ccc866de47fc36d7a [135/136] ACPI: APEI: EINJ: Remove redundant calls to einj_get_available_error_type()
config: x86_64-randconfig-161-20250510 (https://download.01.org/0day-ci/archive/20250511/202505110745.UJtyemor-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202505110745.UJtyemor-lkp@intel.com/
smatch warnings:
drivers/acpi/apei/einj-core.c:769 einj_probe() warn: missing unwind goto?
vim +769 drivers/acpi/apei/einj-core.c
6cb9441bfe8dd7f drivers/acpi/apei/einj-core.c Sudeep Holla 2025-03-17 744 static int __init einj_probe(struct faux_device *fdev)
e40213450b53157 drivers/acpi/apei/einj.c Ying Huang 2010-05-18 745 {
e40213450b53157 drivers/acpi/apei/einj.c Ying Huang 2010-05-18 746 int rc;
e40213450b53157 drivers/acpi/apei/einj.c Ying Huang 2010-05-18 747 acpi_status status;
e40213450b53157 drivers/acpi/apei/einj.c Ying Huang 2010-05-18 748 struct apei_exec_context ctx;
e40213450b53157 drivers/acpi/apei/einj.c Ying Huang 2010-05-18 749
e40213450b53157 drivers/acpi/apei/einj.c Ying Huang 2010-05-18 750 status = acpi_get_table(ACPI_SIG_EINJ, 0,
e40213450b53157 drivers/acpi/apei/einj.c Ying Huang 2010-05-18 751 (struct acpi_table_header **)&einj_tab);
dba648300e890fb drivers/acpi/apei/einj.c Borislav Petkov 2016-05-23 752 if (status == AE_NOT_FOUND) {
5621fafaac0031e drivers/acpi/apei/einj.c Ben Cheatham 2024-03-11 753 pr_debug("EINJ table not found.\n");
e40213450b53157 drivers/acpi/apei/einj.c Ying Huang 2010-05-18 754 return -ENODEV;
37ea9693869627d drivers/acpi/apei/einj.c Jay Lu 2022-12-06 755 } else if (ACPI_FAILURE(status)) {
dba648300e890fb drivers/acpi/apei/einj.c Borislav Petkov 2016-05-23 756 pr_err("Failed to get EINJ table: %s\n",
dba648300e890fb drivers/acpi/apei/einj.c Borislav Petkov 2016-05-23 757 acpi_format_exception(status));
e40213450b53157 drivers/acpi/apei/einj.c Ying Huang 2010-05-18 758 return -EINVAL;
e40213450b53157 drivers/acpi/apei/einj.c Ying Huang 2010-05-18 759 }
e40213450b53157 drivers/acpi/apei/einj.c Ying Huang 2010-05-18 760
e40213450b53157 drivers/acpi/apei/einj.c Ying Huang 2010-05-18 761 rc = einj_check_table(einj_tab);
e40213450b53157 drivers/acpi/apei/einj.c Ying Huang 2010-05-18 762 if (rc) {
d222678426faa5b drivers/acpi/apei/einj.c Colin Ian King 2017-01-17 763 pr_warn(FW_BUG "Invalid EINJ table.\n");
541156a38fd01d9 drivers/acpi/apei/einj.c Hanjun Guo 2020-05-07 764 goto err_put_table;
e40213450b53157 drivers/acpi/apei/einj.c Ying Huang 2010-05-18 765 }
e40213450b53157 drivers/acpi/apei/einj.c Ying Huang 2010-05-18 766
e54b1dc1c4f083c drivers/acpi/apei/einj-core.c Zaid Alali 2025-05-06 767 rc = einj_get_available_error_type(&available_error_type);
e54b1dc1c4f083c drivers/acpi/apei/einj-core.c Zaid Alali 2025-05-06 768 if (rc)
e54b1dc1c4f083c drivers/acpi/apei/einj-core.c Zaid Alali 2025-05-06 @769 return rc;
Should be "goto err_put_table;"
e54b1dc1c4f083c drivers/acpi/apei/einj-core.c Zaid Alali 2025-05-06 770
e40213450b53157 drivers/acpi/apei/einj.c Ying Huang 2010-05-18 771 rc = -ENOMEM;
e40213450b53157 drivers/acpi/apei/einj.c Ying Huang 2010-05-18 772 einj_debug_dir = debugfs_create_dir("einj", apei_get_debugfs_dir());
9ec6dbfbdc0ade8 drivers/acpi/apei/einj.c Greg Kroah-Hartman 2019-01-22 773
9ec6dbfbdc0ade8 drivers/acpi/apei/einj.c Greg Kroah-Hartman 2019-01-22 774 debugfs_create_file("available_error_type", S_IRUSR, einj_debug_dir,
9ec6dbfbdc0ade8 drivers/acpi/apei/einj.c Greg Kroah-Hartman 2019-01-22 775 NULL, &available_error_type_fops);
dcaed592b2fc9ca drivers/acpi/apei/einj.c Rafael J. Wysocki 2019-03-04 776 debugfs_create_file_unsafe("error_type", 0600, einj_debug_dir,
9ec6dbfbdc0ade8 drivers/acpi/apei/einj.c Greg Kroah-Hartman 2019-01-22 777 NULL, &error_type_fops);
dcaed592b2fc9ca drivers/acpi/apei/einj.c Rafael J. Wysocki 2019-03-04 778 debugfs_create_file_unsafe("error_inject", 0200, einj_debug_dir,
9ec6dbfbdc0ade8 drivers/acpi/apei/einj.c Greg Kroah-Hartman 2019-01-22 779 NULL, &error_inject_fops);
e40213450b53157 drivers/acpi/apei/einj.c Ying Huang 2010-05-18 780
e40213450b53157 drivers/acpi/apei/einj.c Ying Huang 2010-05-18 781 apei_resources_init(&einj_resources);
e40213450b53157 drivers/acpi/apei/einj.c Ying Huang 2010-05-18 782 einj_exec_ctx_init(&ctx);
e40213450b53157 drivers/acpi/apei/einj.c Ying Huang 2010-05-18 783 rc = apei_exec_collect_resources(&ctx, &einj_resources);
dba648300e890fb drivers/acpi/apei/einj.c Borislav Petkov 2016-05-23 784 if (rc) {
dba648300e890fb drivers/acpi/apei/einj.c Borislav Petkov 2016-05-23 785 pr_err("Error collecting EINJ resources.\n");
e40213450b53157 drivers/acpi/apei/einj.c Ying Huang 2010-05-18 786 goto err_fini;
dba648300e890fb drivers/acpi/apei/einj.c Borislav Petkov 2016-05-23 787 }
dba648300e890fb drivers/acpi/apei/einj.c Borislav Petkov 2016-05-23 788
e40213450b53157 drivers/acpi/apei/einj.c Ying Huang 2010-05-18 789 rc = apei_resources_request(&einj_resources, "APEI EINJ");
dba648300e890fb drivers/acpi/apei/einj.c Borislav Petkov 2016-05-23 790 if (rc) {
dba648300e890fb drivers/acpi/apei/einj.c Borislav Petkov 2016-05-23 791 pr_err("Error requesting memory/port resources.\n");
e40213450b53157 drivers/acpi/apei/einj.c Ying Huang 2010-05-18 792 goto err_fini;
dba648300e890fb drivers/acpi/apei/einj.c Borislav Petkov 2016-05-23 793 }
dba648300e890fb drivers/acpi/apei/einj.c Borislav Petkov 2016-05-23 794
e40213450b53157 drivers/acpi/apei/einj.c Ying Huang 2010-05-18 795 rc = apei_exec_pre_map_gars(&ctx);
dba648300e890fb drivers/acpi/apei/einj.c Borislav Petkov 2016-05-23 796 if (rc) {
dba648300e890fb drivers/acpi/apei/einj.c Borislav Petkov 2016-05-23 797 pr_err("Error pre-mapping GARs.\n");
e40213450b53157 drivers/acpi/apei/einj.c Ying Huang 2010-05-18 798 goto err_release;
dba648300e890fb drivers/acpi/apei/einj.c Borislav Petkov 2016-05-23 799 }
c130bd6f82e5dda drivers/acpi/apei/einj.c Tony Luck 2012-01-17 800
c130bd6f82e5dda drivers/acpi/apei/einj.c Tony Luck 2012-01-17 801 einj_param = einj_get_parameter_address();
c130bd6f82e5dda drivers/acpi/apei/einj.c Tony Luck 2012-01-17 802 if ((param_extension || acpi5) && einj_param) {
9ec6dbfbdc0ade8 drivers/acpi/apei/einj.c Greg Kroah-Hartman 2019-01-22 803 debugfs_create_x32("flags", S_IRUSR | S_IWUSR, einj_debug_dir,
9ec6dbfbdc0ade8 drivers/acpi/apei/einj.c Greg Kroah-Hartman 2019-01-22 804 &error_flags);
9ec6dbfbdc0ade8 drivers/acpi/apei/einj.c Greg Kroah-Hartman 2019-01-22 805 debugfs_create_x64("param1", S_IRUSR | S_IWUSR, einj_debug_dir,
9ec6dbfbdc0ade8 drivers/acpi/apei/einj.c Greg Kroah-Hartman 2019-01-22 806 &error_param1);
9ec6dbfbdc0ade8 drivers/acpi/apei/einj.c Greg Kroah-Hartman 2019-01-22 807 debugfs_create_x64("param2", S_IRUSR | S_IWUSR, einj_debug_dir,
9ec6dbfbdc0ade8 drivers/acpi/apei/einj.c Greg Kroah-Hartman 2019-01-22 808 &error_param2);
9ec6dbfbdc0ade8 drivers/acpi/apei/einj.c Greg Kroah-Hartman 2019-01-22 809 debugfs_create_x64("param3", S_IRUSR | S_IWUSR, einj_debug_dir,
9ec6dbfbdc0ade8 drivers/acpi/apei/einj.c Greg Kroah-Hartman 2019-01-22 810 &error_param3);
9ec6dbfbdc0ade8 drivers/acpi/apei/einj.c Greg Kroah-Hartman 2019-01-22 811 debugfs_create_x64("param4", S_IRUSR | S_IWUSR, einj_debug_dir,
9ec6dbfbdc0ade8 drivers/acpi/apei/einj.c Greg Kroah-Hartman 2019-01-22 812 &error_param4);
9ec6dbfbdc0ade8 drivers/acpi/apei/einj.c Greg Kroah-Hartman 2019-01-22 813 debugfs_create_x32("notrigger", S_IRUSR | S_IWUSR,
ee49089dc7d9fc7 drivers/acpi/apei/einj.c Chen Gong 2012-03-15 814 einj_debug_dir, ¬rigger);
c130bd6f82e5dda drivers/acpi/apei/einj.c Tony Luck 2012-01-17 815 }
c130bd6f82e5dda drivers/acpi/apei/einj.c Tony Luck 2012-01-17 816
c130bd6f82e5dda drivers/acpi/apei/einj.c Tony Luck 2012-01-17 817 if (vendor_dev[0]) {
c130bd6f82e5dda drivers/acpi/apei/einj.c Tony Luck 2012-01-17 818 vendor_blob.data = vendor_dev;
c130bd6f82e5dda drivers/acpi/apei/einj.c Tony Luck 2012-01-17 819 vendor_blob.size = strlen(vendor_dev);
9ec6dbfbdc0ade8 drivers/acpi/apei/einj.c Greg Kroah-Hartman 2019-01-22 820 debugfs_create_blob("vendor", S_IRUSR, einj_debug_dir,
9ec6dbfbdc0ade8 drivers/acpi/apei/einj.c Greg Kroah-Hartman 2019-01-22 821 &vendor_blob);
9ec6dbfbdc0ade8 drivers/acpi/apei/einj.c Greg Kroah-Hartman 2019-01-22 822 debugfs_create_x32("vendor_flags", S_IRUSR | S_IWUSR,
c130bd6f82e5dda drivers/acpi/apei/einj.c Tony Luck 2012-01-17 823 einj_debug_dir, &vendor_flags);
6e320ec1d98f9eb drivers/acpi/apei/einj.c Ying Huang 2010-05-18 824 }
e40213450b53157 drivers/acpi/apei/einj.c Ying Huang 2010-05-18 825
22fca621bd1bbc5 drivers/acpi/apei/einj.c Avadhut Naik 2023-11-16 826 if (vendor_errors.size)
22fca621bd1bbc5 drivers/acpi/apei/einj.c Avadhut Naik 2023-11-16 827 debugfs_create_blob("oem_error", 0600, einj_debug_dir,
22fca621bd1bbc5 drivers/acpi/apei/einj.c Avadhut Naik 2023-11-16 828 &vendor_errors);
22fca621bd1bbc5 drivers/acpi/apei/einj.c Avadhut Naik 2023-11-16 829
b2f740baa421525 drivers/acpi/apei/einj.c Borislav Petkov 2016-05-23 830 pr_info("Error INJection is initialized.\n");
e40213450b53157 drivers/acpi/apei/einj.c Ying Huang 2010-05-18 831
e40213450b53157 drivers/acpi/apei/einj.c Ying Huang 2010-05-18 832 return 0;
e40213450b53157 drivers/acpi/apei/einj.c Ying Huang 2010-05-18 833
e40213450b53157 drivers/acpi/apei/einj.c Ying Huang 2010-05-18 834 err_release:
e40213450b53157 drivers/acpi/apei/einj.c Ying Huang 2010-05-18 835 apei_resources_release(&einj_resources);
e40213450b53157 drivers/acpi/apei/einj.c Ying Huang 2010-05-18 836 err_fini:
e40213450b53157 drivers/acpi/apei/einj.c Ying Huang 2010-05-18 837 apei_resources_fini(&einj_resources);
e40213450b53157 drivers/acpi/apei/einj.c Ying Huang 2010-05-18 838 debugfs_remove_recursive(einj_debug_dir);
541156a38fd01d9 drivers/acpi/apei/einj.c Hanjun Guo 2020-05-07 839 err_put_table:
541156a38fd01d9 drivers/acpi/apei/einj.c Hanjun Guo 2020-05-07 840 acpi_put_table((struct acpi_table_header *)einj_tab);
e40213450b53157 drivers/acpi/apei/einj.c Ying Huang 2010-05-18 841
e40213450b53157 drivers/acpi/apei/einj.c Ying Huang 2010-05-18 842 return rc;
e40213450b53157 drivers/acpi/apei/einj.c Ying Huang 2010-05-18 843 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2025-05-13 14:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0899a8f6-5880-49dc-b699-e369719280e1@suswa.mountain \
--to=dan.carpenter@linaro.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=devel@acpica.org \
--cc=ira.weiny@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=rjw@rjwysocki.net \
--cc=zaidal@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox