From: Viresh Kumar <viresh.kumar@linaro.org>
To: Rafael Wysocki <rjw@rjwysocki.net>, yuantian.tang@freescale.com
Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
hongbo.zhang@freescale.com, leoli@freescale.com,
Viresh Kumar <viresh.kumar@linaro.org>
Subject: [PATCH 1/2] cpufreq: ppc-corenet: remove duplicate update of cpu_data
Date: Tue, 2 Sep 2014 09:11:24 +0530 [thread overview]
Message-ID: <09092df3d8b03df99ee475357c5f5c9cc439c61c.1409629117.git.viresh.kumar@linaro.org> (raw)
'cpu_data' is updated for policy->cpu first and then for all CPUs in
policy->cpus. policy->cpus is guaranteed to contain policy->cpu as well and so
the first write to 'cpu_data' for policy->cpu is redundant. Remove it.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
Hi Yuantian,
I was looking into this driver due to issues reported by Hongtao (cc'd) and
found that we can live without some code. These aren't fixing any bugs and are
just cleanups.
I didn't had a compiler for this and so this isn't even compiled. It would be
great if you can please review/test these patches.
drivers/cpufreq/ppc-corenet-cpufreq.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/cpufreq/ppc-corenet-cpufreq.c b/drivers/cpufreq/ppc-corenet-cpufreq.c
index 3607070..bee5df7 100644
--- a/drivers/cpufreq/ppc-corenet-cpufreq.c
+++ b/drivers/cpufreq/ppc-corenet-cpufreq.c
@@ -199,7 +199,6 @@ static int corenet_cpufreq_cpu_init(struct cpufreq_policy *policy)
}
data->table = table;
- per_cpu(cpu_data, cpu) = data;
/* update ->cpus if we have cluster, no harm if not */
cpumask_copy(policy->cpus, per_cpu(cpu_mask, cpu));
--
2.0.3.693.g996b0fd
next reply other threads:[~2014-09-02 3:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 3:41 Viresh Kumar [this message]
2014-09-02 3:41 ` [PATCH 2/2] cpufreq: ppc-corenet: remove per-cpu variable 'cpu_mask' Viresh Kumar
2014-09-02 6:46 ` Yuantian Tang
2014-09-02 6:49 ` Viresh Kumar
2014-09-02 7:02 ` Yuantian Tang
2014-09-02 7:09 ` Viresh Kumar
2014-09-02 8:08 ` Yuantian Tang
2014-09-03 8:02 ` Yuantian Tang
2014-09-03 9:50 ` Viresh Kumar
2014-09-04 2:51 ` Yuantian Tang
2014-09-04 3:38 ` Viresh Kumar
2014-09-04 4:33 ` Yuantian Tang
2014-09-04 4:37 ` Viresh Kumar
2014-09-05 9:35 ` Yuantian Tang
2014-09-05 9:40 ` Viresh Kumar
2014-09-02 6:38 ` [PATCH 1/2] cpufreq: ppc-corenet: remove duplicate update of cpu_data Yuantian Tang
2014-09-02 6:47 ` Viresh Kumar
2014-09-10 4:32 ` Viresh Kumar
2014-09-10 5:30 ` Yuantian Tang
2014-09-10 5:39 ` Viresh Kumar
2014-09-10 6:19 ` Yuantian Tang
2014-09-10 6:20 ` Yuantian Tang
2014-09-24 23:45 ` Rafael J. Wysocki
2014-09-29 9:05 ` Viresh Kumar
2014-09-29 23:41 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09092df3d8b03df99ee475357c5f5c9cc439c61c.1409629117.git.viresh.kumar@linaro.org \
--to=viresh.kumar@linaro.org \
--cc=hongbo.zhang@freescale.com \
--cc=leoli@freescale.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=yuantian.tang@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).