From: YangYang <yang.yang@vivo.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Bart Van Assche <bvanassche@acm.org>,
Jens Axboe <axboe@kernel.dk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Danilo Krummrich <dakr@kernel.org>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH v1] PM: sleep: Do not flag runtime PM workqueue as freezable
Date: Tue, 2 Dec 2025 18:36:58 +0800 [thread overview]
Message-ID: <0b8c07a6-de96-4091-96db-71fa6b95a8f7@vivo.com> (raw)
In-Reply-To: <6216669.lOV4Wx5bFT@rafael.j.wysocki>
On 2025/12/2 3:58, Rafael J. Wysocki wrote:
> On Monday, December 1, 2025 7:47:46 PM CET Rafael J. Wysocki wrote:
>> On Mon, Dec 1, 2025 at 10:46 AM YangYang <yang.yang@vivo.com> wrote:
>
> [cut]
>
>> If blk_queue_enter() or __bio_queue_enter() is allowed to race with
>> disabling runtime PM for q->dev, failure to resume q->dev is alway
>> possible and there are no changes that can be made to
>> pm_runtime_disable() to prevent that from happening. If
>> __pm_runtime_disable() wins the race, it will increment
>> power.disable_depth and rpm_resume() will bail out when it sees that
>> no matter what.
>>
>> You should not conflate "runtime PM doesn't work when it is disabled"
>> with "asynchronous runtime PM doesn't work after freezing the PM
>> workqueue". They are both true, but they are not the same.
>
> So I've been testing the patch below for a few days and it will eliminate
> the latter, but even after this patch runtime PM will be disabled in
> device_suspend_late() and if the problem you are facing is still there
> after this patch, it will need to dealt with at the driver level.
>
> Generally speaking, driver involvement is needed to make runtime PM and
> system suspend/resume work together in the majority of cases.
>
Thank you. I'll perform some tests with this patch applied.
next prev parent reply other threads:[~2025-12-02 10:37 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 10:16 [PATCH 0/2] PM: runtime: Fix potential I/O hang Yang Yang
2025-11-26 10:16 ` [PATCH 1/2] PM: runtime: Fix I/O hang due to race between resume and runtime disable Yang Yang
2025-11-26 11:30 ` Rafael J. Wysocki
2025-11-26 11:59 ` YangYang
2025-11-26 12:36 ` Rafael J. Wysocki
2025-11-26 15:33 ` Bart Van Assche
2025-11-26 15:41 ` Rafael J. Wysocki
2025-11-26 18:40 ` Bart Van Assche
2025-11-27 11:29 ` YangYang
2025-11-27 12:44 ` Rafael J. Wysocki
2025-11-28 7:20 ` YangYang
2025-12-01 16:40 ` Bart Van Assche
2025-11-26 18:06 ` Bart Van Assche
2025-11-26 19:16 ` Rafael J. Wysocki
2025-11-26 19:34 ` Rafael J. Wysocki
2025-11-26 20:17 ` Rafael J. Wysocki
2025-11-26 21:10 ` Bart Van Assche
2025-11-26 21:30 ` Rafael J. Wysocki
2025-11-26 22:47 ` Bart Van Assche
2025-11-27 12:34 ` Rafael J. Wysocki
2025-12-01 9:46 ` YangYang
2025-12-01 12:56 ` YangYang
2025-12-01 18:55 ` Rafael J. Wysocki
2025-12-02 10:33 ` YangYang
2025-12-02 12:18 ` Rafael J. Wysocki
2025-12-01 18:47 ` Rafael J. Wysocki
2025-12-01 19:58 ` [PATCH v1] PM: sleep: Do not flag runtime PM workqueue as freezable Rafael J. Wysocki
2025-12-02 1:06 ` Bart Van Assche
2025-12-02 11:53 ` Rafael J. Wysocki
2025-12-02 13:29 ` Rafael J. Wysocki
2025-12-02 10:36 ` YangYang [this message]
2025-12-02 14:58 ` Ulf Hansson
2025-12-02 0:40 ` [PATCH 1/2] PM: runtime: Fix I/O hang due to race between resume and runtime disable Bart Van Assche
2025-12-02 12:14 ` Rafael J. Wysocki
2025-12-02 13:37 ` Rafael J. Wysocki
2025-12-05 15:24 ` [PATCH v2] PM: sleep: Do not flag runtime PM workqueue as freezable Rafael J. Wysocki
2025-12-05 19:10 ` Bart Van Assche
2025-12-07 11:23 ` Rafael J. Wysocki
2025-11-26 10:16 ` [PATCH 2/2] blk-mq: Fix I/O hang caused by incomplete device resume Yang Yang
2025-11-26 11:31 ` [PATCH 0/2] PM: runtime: Fix potential I/O hang Rafael J. Wysocki
2025-11-26 15:48 ` Bart Van Assche
2025-11-26 16:59 ` Rafael J. Wysocki
2025-11-26 17:21 ` Rafael J. Wysocki
2025-11-26 17:34 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b8c07a6-de96-4091-96db-71fa6b95a8f7@vivo.com \
--to=yang.yang@vivo.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=dakr@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox