From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Varadarajan Narayanan <quic_varada@quicinc.com>
Cc: andersson@kernel.org, mturquette@baylibre.com, sboyd@kernel.org,
robh@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, djakov@kernel.org, quic_anusha@quicinc.com,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v6 2/6] interconnect: icc-clk: Remove tristate from INTERCONNECT_CLK
Date: Tue, 2 Apr 2024 16:49:33 +0200 [thread overview]
Message-ID: <0e599137-4a23-40b9-9a22-3c32f795fa1b@linaro.org> (raw)
In-Reply-To: <CAA8EJppyuagb5zkP4LCjjJwConw3mw3iS-+dO7YB01=7-waRTw@mail.gmail.com>
On 2.04.2024 12:39 PM, Dmitry Baryshkov wrote:
> On Tue, 2 Apr 2024 at 13:34, Varadarajan Narayanan
> <quic_varada@quicinc.com> wrote:
>>
>> drivers/clk/qcom/common.c uses devm_icc_clk_register under
>> IS_ENABLED(CONFIG_INTERCONNECT_CLK). However, in kernel bot
>> random config build test, with the following combination
>>
>> CONFIG_COMMON_CLK_QCOM=y
>> and
>> CONFIG_INTERCONNECT_CLK=m
>>
>> the following error is seen as devm_icc_clk_register is in a
>> module and being referenced from vmlinux.
>>
>> powerpc64-linux-ld: drivers/clk/qcom/common.o: in function `qcom_cc_really_probe':
>> >> common.c:(.text+0x980): undefined reference to `devm_icc_clk_register'
>>
>> Hence, ensure INTERCONNECT_CLK is not selected as a module.
>
> NAK. Please use `depends on INTERCONNECT_CLK || !INTERCONNECT_CLK` in
> your Kconfig dependencies.
Should icc-clk ever be built as a module? It really seems like it should be
a part of the core framework.. And dependency management would be easier
Konrad
next prev parent reply other threads:[~2024-04-02 14:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 10:34 [PATCH v6 0/6] Add interconnect driver for IPQ9574 SoC Varadarajan Narayanan
2024-04-02 10:34 ` [PATCH v6 1/6] dt-bindings: interconnect: Add Qualcomm IPQ9574 support Varadarajan Narayanan
2024-04-03 7:09 ` Krzysztof Kozlowski
2024-04-03 10:44 ` Varadarajan Narayanan
2024-04-02 10:34 ` [PATCH v6 2/6] interconnect: icc-clk: Remove tristate from INTERCONNECT_CLK Varadarajan Narayanan
2024-04-02 10:39 ` Dmitry Baryshkov
2024-04-02 14:49 ` Konrad Dybcio [this message]
2024-04-03 15:42 ` kernel test robot
2024-04-02 10:34 ` [PATCH v6 3/6] interconnect: icc-clk: Add devm_icc_clk_register Varadarajan Narayanan
2024-04-02 10:40 ` Dmitry Baryshkov
2024-04-02 10:48 ` Dmitry Baryshkov
2024-04-02 11:02 ` Varadarajan Narayanan
2024-04-02 11:16 ` Dmitry Baryshkov
2024-04-02 11:22 ` Varadarajan Narayanan
2024-04-02 12:12 ` Dmitry Baryshkov
2024-04-03 10:45 ` Varadarajan Narayanan
2024-04-02 10:34 ` [PATCH v6 4/6] clk: qcom: common: Add interconnect clocks support Varadarajan Narayanan
2024-04-02 10:48 ` Dmitry Baryshkov
2024-04-02 11:05 ` Varadarajan Narayanan
2024-04-02 10:34 ` [PATCH v6 5/6] clk: qcom: ipq9574: Use icc-clk for enabling NoC related clocks Varadarajan Narayanan
2024-04-02 10:34 ` [PATCH v6 6/6] arm64: dts: qcom: ipq9574: Add icc provider ability to gcc Varadarajan Narayanan
2024-04-02 10:48 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e599137-4a23-40b9-9a22-3c32f795fa1b@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mturquette@baylibre.com \
--cc=quic_anusha@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox