* [PATCH] cpufreq: acpi-cpufreq: Don't set policy->related_cpus from .init()
@ 2013-03-24 15:58 Viresh Kumar
0 siblings, 0 replies; only message in thread
From: Viresh Kumar @ 2013-03-24 15:58 UTC (permalink / raw)
To: rjw
Cc: arvind.chauhan, robin.randhawa, Steve.Bannister, Liviu.Dudau,
charles.garcia-tobin, cpufreq, linux-pm, linux-kernel,
linaro-kernel, Viresh Kumar
With the addition of following patch:
fcf8058 cpufreq: Simplify cpufreq_add_dev()
cpufreq driver's .init() routine must initialize policy->cpus with mask of all
possible cpus (Online + Offline) that share the clock. Then the core would copy
this mask onto policy->related_cpus and will reset policy->cpus to carry only
online cpus.
acpi-cpufreq driver wasn't updated with this assumption and so sometimes when
we try to hot[un]plug cpus at run time, sysfs directories gets corrupted.
This patch fixes acpi-cpufreq driver against this corruption.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Tested-by: Maciej Rutecki <maciej.rutecki@gmail.com>
---
drivers/cpufreq/acpi-cpufreq.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
index afbef9c..11b8b4b 100644
--- a/drivers/cpufreq/acpi-cpufreq.c
+++ b/drivers/cpufreq/acpi-cpufreq.c
@@ -723,7 +723,6 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy)
policy->shared_type == CPUFREQ_SHARED_TYPE_ANY) {
cpumask_copy(policy->cpus, perf->shared_cpu_map);
}
- cpumask_copy(policy->related_cpus, perf->shared_cpu_map);
#ifdef CONFIG_SMP
dmi_check_system(sw_any_bug_dmi_table);
@@ -735,7 +734,6 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy)
if (check_amd_hwpstate_cpu(cpu) && !acpi_pstate_strict) {
cpumask_clear(policy->cpus);
cpumask_set_cpu(cpu, policy->cpus);
- cpumask_copy(policy->related_cpus, cpu_sibling_mask(cpu));
policy->shared_type = CPUFREQ_SHARED_TYPE_HW;
pr_info_once(PFX "overriding BIOS provided _PSD data\n");
}
--
1.7.12.rc2.18.g61b472e
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2013-03-24 15:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-24 15:58 [PATCH] cpufreq: acpi-cpufreq: Don't set policy->related_cpus from .init() Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).