From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7AD332D0D0 for ; Tue, 6 Jan 2026 14:47:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767710842; cv=none; b=L2EzhVBW6QsUT+H6X/r4kNB3bbFt0dgHlNZRVFgVr3k3qTEIC+RKJrkRgR9nEZnHJK84XxfyR4n2htdyAjyN+SGV18ZXr5I8ERHWoPg1qX6PLa/rr7aDvH+qFeGiO3vQQxgaGnYvL4IhXg4jnb3gyGht66wy3jdswjFl23X3KKo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767710842; c=relaxed/simple; bh=1BLBAQMk8pTE3hF64+V13g2KSdCDa8b+lx+TiAfkmfg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SnhNEkgsJa5/IOXBXIYDCXyz8Cxx1Lf+dkN3mIvTbJjjvzVgifZYg86+ORDXsb5m+YR8uGKGXnTJlhtM9S5rKEMhZcI6J1wTwoudPzF3iOOvWqTTRaf/MNIHQg5UgpSOeV7HOsHEi5keBdXMkpwF4wUu5knsBJD4kZwE4iwLGsQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bAr0MDmy; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=d6dLLUxk; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bAr0MDmy"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="d6dLLUxk" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 606AlAdK3052758 for ; Tue, 6 Jan 2026 14:47:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= zcfsFS04VN0Soi3THqaIkbsPmr9ODp+iS17uQAxtAY8=; b=bAr0MDmyIkL6yg9w SUhQGeEyloBC+6OLCP+Q9x2cmKDih9Qt2O+RNLsXi+P/5JNviDJTAJAmyG+UW7XS 8Yc9YKoxhy4wpIJ5o0PBYb+uOceiEHUa/iLd1hDEn0c6mNCIaDsRp0XX0BTVd0h7 bJ5XZVpd8fyWllMfnz82uX03oAnq5b4xGClzIF52jRziejYayiPJX/yrdy5nY3j7 7YAnA53HsbgyrLtRNLH+60i6G8UNG4ra7KGvPOw1SJdMS4Xqf7j56B6L3mManify wn7cZTudXPInisJ96H0WIkOlaMzv059RiOyYygntr9ulFgv5habNGxs522wp3IMj UkSAyg== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bgpn9tc5b-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 06 Jan 2026 14:47:19 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-34cc8bf226cso2667014a91.3 for ; Tue, 06 Jan 2026 06:47:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767710838; x=1768315638; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zcfsFS04VN0Soi3THqaIkbsPmr9ODp+iS17uQAxtAY8=; b=d6dLLUxkXJ6kY0M/MCiQIRn2/WaW/HxBjUiRqQJp4DHicbr99w5Z4g1wyzHXBWRtWX t6i499brNVyFS9gW8fE3tAJ2LGCbyzWDY2fNJR4yybu6hWEPK6MbngY0bV2RCc+NQMit LCn0p1gP3X8TwRlFHWrfUEw1qQxPOQdjJzXAOvKyPCGnow8EJTSlwqNwO3x6euH8dyyn C89xS64P51kTFG0IYLTBOeR6ajn4L6eZiATW/YFGXXWHMo0iky9qVwet1r1ZYZNdxswA HJKRcnDMGdxMlIFqiKYK2ByLMcacmgEXolFb3J9pwprEC5xPaXme/vRiXm3x0Y6Ih/Eu WTGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767710838; x=1768315638; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zcfsFS04VN0Soi3THqaIkbsPmr9ODp+iS17uQAxtAY8=; b=KWKmA77Cdica6P6QMQRFsIF0xZD99S34yz83GhG765ZUNLE13bqTCCPXMZt/hZDFgT yw2L+k04DVbdbleahK6hHd3mR6c5iXW+IRqiJ0sd7KCWviRpguP0ZlPRypxNVP2vVDj6 mvxG/U7k8cZO59Qw+49zvYo//6KUBUMoI97pOBKWsripXCFFAXKqHqrG+dLTnAj8PCfG b3OpPaklpqaGJOmu1NT3udDZ+tqrsQqsFU1nv1uolxfsKaaNQ8iMwtcyL5ui9xbp0D+F MQLEny/4K16Stw5B2lZDfSyEaeKH74fIY3mfVN0eYvge/7865MMh3jzGj8cAT8khCyYv IXNA== X-Forwarded-Encrypted: i=1; AJvYcCVEy6UwEwkXKx/vY2BKJtHJsVAmXO1atAk6f/yFXWgycpWQJkURumjxNDVXZl8UWd9m1i4J1i/Mxg==@vger.kernel.org X-Gm-Message-State: AOJu0Yz4TmJotJRKcSQiRiifvoep6Gg1gh2Hn8oeCNDYGmZyMewO7CMK 1HErdCvHXBO49RHb/o5+2Qmk30Y8aM8OMT3nkQi0eRr8bYqKX8Hur5kfEGewmS+Z+2awghbFV6p mwVJWq4nBPsArnEAN6UETDJXpqlPlo2fcWVGEEc7zsl0ODRP+yOED5nam0z5BFA== X-Gm-Gg: AY/fxX6MhMRd6fZD90svF6WqxtekD/EXCdMc2CftTcUP6EdN39hUjfYc6zTwSfh9Rn9 4i9k9y1CHSPAFl7F2ySGRybwqanZSrZbVfQtD8NIfSYyHdqhumXqFVIlNjJ0bBQgadfSTI5iGS3 5clX5Ev8zk8fbUQDGJqHWyvbwu1Wi62SEpH4clKW9SflHXJd1UYWG+5EHJKXX4AHMnz7hioHZqz AaUE4D/Ud7vizxunQ3adX29vxUf1MQ2xpSbNRDtaRN5zeIpJNRW+Jv4oo2cJIvSDc5CKmgRiz1a TgZa8e2hZEGoLewGz5WiQGwyY+Ri+6uV2KRzh8cUPtL9cPwUxgRfT7z4pSLPqV0dp1Z29+6sKwn Zy+KG3B6iw7/0DhUPNgR0ft4SUlG4UL1nDstssfJkD2Q= X-Received: by 2002:a17:90b:4f88:b0:32e:5646:d448 with SMTP id 98e67ed59e1d1-34f5f30038bmr2743071a91.21.1767710838394; Tue, 06 Jan 2026 06:47:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IGNSDUxkQhO/yV3l5ELdMmGOkQbRz1mErp+pZNgrdUbiWyRnlViktR5bVwFxL5b/wwflX2M1A== X-Received: by 2002:a17:90b:4f88:b0:32e:5646:d448 with SMTP id 98e67ed59e1d1-34f5f30038bmr2743028a91.21.1767710837911; Tue, 06 Jan 2026 06:47:17 -0800 (PST) Received: from [10.216.40.68] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c4cc8d29521sm2634999a12.23.2026.01.06.06.47.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Jan 2026 06:47:17 -0800 (PST) Message-ID: <107b43ab-85fe-8b09-a622-854f9672f45f@oss.qualcomm.com> Date: Tue, 6 Jan 2026 20:17:08 +0530 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v19 01/10] power: reset: reboot-mode: Remove devres based allocations Content-Language: en-US To: Bartosz Golaszewski Cc: Dmitry Baryshkov , Lorenzo Pieralisi , Arnd Bergmann , Bjorn Andersson , Sebastian Reichel , Rob Herring , Sudeep Holla , Souvik Chakravarty , Krzysztof Kozlowski , Andy Yan , John Stultz , Matthias Brugger , Moritz Fischer , Mark Rutland , Conor Dooley , Konrad Dybcio , Florian Fainelli , Krzysztof Kozlowski , Mukesh Ojha , Andre Draszik , Kathiravan Thirumoorthy , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Srinivas Kandagatla References: <20251228-arm-psci-system_reset2-vendor-reboots-v19-0-ebb956053098@oss.qualcomm.com> <20251228-arm-psci-system_reset2-vendor-reboots-v19-1-ebb956053098@oss.qualcomm.com> From: Shivendra Pratap In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: y-bb2X5CcHxUCekf0JUB6lFpGLBu_7VJ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA2MDEyOCBTYWx0ZWRfXyOUEbpkpbblJ UAh2LhAJCPyarqaSQoSu7O0KRtmdSrhY2qMLGOrmKtGUP/hSPmxjJwwMosvfjL018xwcFvirmL1 2J5pEVCbyPniQZkxxrR6wiigNbiBpCXyWMAsA07TODIhSPiDZWSBxlpwwPKnIta5lx1gd39nf59 JajSMnY8CZ1W02ZK+tdbAejK0WFu1uwQCXact08l2OobfWiLQB40FNT3oN81Hn/5LZfg0y5D4ya 6+ZouPLuznKHUJRwpsj4aXHS1rO/1wwroqnPTEfR/d6NyxRM9MttNr+tDkq7BZYyA0+AzL9++ki CxCAs43WN2CiP6VjLpVX09L0p3n7FnCpZrB35+CAy/CZeIYTiHmYoW+V6c5mSlY0iv3tzWJbw3Z Zz24Crq5CJzmpSvalNsLyHlDztEuOFnba8NE6JQ+aE97NxIv7qNvLyWhSVAdzszSH7QTLU2H4wT ALz9G/5EyNi91RxUpyA== X-Proofpoint-GUID: y-bb2X5CcHxUCekf0JUB6lFpGLBu_7VJ X-Authority-Analysis: v=2.4 cv=KfnfcAYD c=1 sm=1 tr=0 ts=695d2077 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=uBB1BXs7VCbqA7mTJTUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-06_01,2026-01-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 clxscore=1015 spamscore=0 adultscore=0 suspectscore=0 malwarescore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601060128 On 1/6/2026 6:00 PM, Bartosz Golaszewski wrote: > On Tue, Jan 6, 2026 at 7:31 AM Shivendra Pratap > wrote: >> >> >> >> On 1/6/2026 3:01 AM, Dmitry Baryshkov wrote: >>> On Mon, Jan 05, 2026 at 11:46:40PM +0530, Shivendra Pratap wrote: >>>> >>>> >>>> On 1/2/2026 3:35 PM, Bartosz Golaszewski wrote: >>>>> On Sun, Dec 28, 2025 at 6:20 PM Shivendra Pratap >>>>> wrote: >>>> >>>> [snip] >>>> >>>>> >>>>>> + pr_err("reboot mode %s without magic number\n", prop->name); >>>>> >>>>> If this is an error, shouldn't we bail out? >>>>> >>>>>> + continue; >>>> >>>> This is not an error as per original design of reboot-mode framework. >>>> The code as of now says, if the reboot-mode node has an entry without >>>> proper magic value, ignore it, and, process the next. >>> >>> Then why are you using error level for the message printout? >> >> I have changed from dev_err to pr_err. Can make it pr_info. Will >> that change need a mention in commit text? >> > > If we can ignore something safely, then I'd just use pr_debug(). Ack. thanks, Shivendra