Re: Nested suspends; messages vs. states

Nigel Cunningham
2005-03-23T21:35:51Z

[-- Attachment #1: Type: text/plain, Size: 818 bytes --]

Hi.

On Thu, 2005-03-24 at 08:02, Pavel Machek wrote:
> Yes.
>
> There are many drivers that do not fit your idea of "driver". Like
> mtrrs. Some drivers only ever do work on resume, etc. Forcing driver
> to think how to split it into class->stop, bus->save_state and
> bus->enter state is bad idea. [Notice that almost no drivers need
> ->save_state operation...]

I don't think MTRRs should be counted as drivers. Rather, they should be
counted as part of the CPU state(s), to be saved and restored when CPU
context is saved and restored. Treating them as drivers leads to races
:>

Regards,

Nigel
--
Nigel Cunningham
Software Engineer, Canberra, Australia
http://www.cyclades.com
Bus: +61 (2) 6291 9554; Hme: +61 (2) 6292 8028; Mob: +61 (417) 100 574

Maintainer of Suspend2 Kernel Patches http://suspend2.net