chainsawing disk.c, need discussion

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

[-- Attachment #1: Type: text/plain, Size: 985 bytes --]

Hi Pavel !

I'm in the middle of killing the pile of junk that is
kernel/power/disk.c but I think we need to discuss some of this on irc,
as email has a too much latency here.

It's just a big nonsense that we duplicate so much code between
kernel/power/main.c and don't have consistency in the callbacks. The
whole in_suspend trick is also disgusting (but may need some low level
fixes to be removed) and I think not calling the arch callbacks when
they exist when the "mode" is reboot or shutdown simply makes no sense.

So please, let me know when you can be around, I'd really want to clean
that up, I don't plan to touch the guts of swsusp itself (except maybe
for removing that in_suspend thing by having swsusp_suspend() return 1
for the "in suspend" case and 0 for the "resumed" case, which may
require some arch small fixes, but that's pretty much all), I really
only want to fix & consolidate main.c and disk.c which are needlessly
inconsitent at the moment.

Cheers,
Ben.



[-- Attachment #2: Type: text/plain, Size: 0 bytes --]