Re: Re: [PATCH 1/23] Add missing device_suspsend(PMSG_FREEZE) calls.

Shaohua Li
2005-07-28T02:44:17Z

[-- Attachment #1: Type: text/plain, Size: 1000 bytes --]

On Wed, 2005-07-27 at 19:12 -0600, Eric W. Biederman wrote:
> Nigel Cunningham <ncunningham@cyclades.com> writes:
>
> > Hi.
> >
> > Could you please send PMSG_* related patches to linux-pm at
> > lists.osdl.org as well?
>
> I'll try. My goal was not to add or change not functionality but to
> make what the kernel was already doing be consistent.
>
> It turns out the device_suspend(PMSG_FREEZE) is a major pain
> sitting in the reboot path and I will be submitting a patch to
> remove it from the reboot path in 2.6.13 completely.
>
> At the very least the ide driver breaks, and the e1000 driver
> is affected.
>
> And there is of course the puzzle of why there exists simultaneously
> driver shutdown() and suspend(PMSG_FREEZE) methods as I believed they
> are defined to do exactly the same thing.
I would expect more driver breakage and for the shutdown either. In
current stage, suspend(PMSG_FREEZE) might put devices into D3 state. How
can a shutdown() be done again?

Thanks,
Shaohua