From: Nigel Cunningham <ncunningham@cyclades.com>
To: Li Shaohua <shaohua.li@intel.com>
Cc: Linux-pm mailing list <linux-pm@lists.osdl.org>
Subject: Re: [RFC] change suspend_finish order slightly
Date: Sun, 04 Dec 2005 23:55:41 +1000 [thread overview]
Message-ID: <1133704474.5993.14.camel@laptop.cunninghams> (raw)
In-Reply-To: <1133579748.7835.6.camel@linux.site>
[-- Attachment #1: Type: text/plain, Size: 1448 bytes --]
Hi.
On Sat, 2005-12-03 at 13:15, Shaohua Li wrote:
> The BIOS guys here require ACPI _WAK method which is called in
> pm_ops->finish is invoked after all CPUs are resumed. Detail info can be
> found at http://bugzilla.kernel.org/show_bug.cgi?id=5651. To do this,
> this patch tries to change the order slightly. Does this break other
> platforms?
Is it needed even if you call the prepare after hot unplugging other
cpus? (If so, I need to modify suspend2, too).
Regards,
Nigel
> Thanks,
> Shaohua
> ---
>
> linux-2.6.14-root/kernel/power/main.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff -puN kernel/power/main.c~smp_s3_order kernel/power/main.c
> --- linux-2.6.14/kernel/power/main.c~smp_s3_order 2005-11-03 14:18:29.000000000 +0800
> +++ linux-2.6.14-root/kernel/power/main.c 2005-11-03 14:21:05.000000000 +0800
> @@ -133,10 +133,10 @@ static int suspend_enter(suspend_state_t
> static void suspend_finish(suspend_state_t state)
> {
> device_resume();
> - if (pm_ops && pm_ops->finish)
> - pm_ops->finish(state);
> thaw_processes();
> enable_nonboot_cpus();
> + if (pm_ops && pm_ops->finish)
> + pm_ops->finish(state);
> pm_restore_console();
> }
>
> _
>
>
>
> ______________________________________________________________________
> _______________________________________________
> linux-pm mailing list
> linux-pm@lists.osdl.org
> https://lists.osdl.org/mailman/listinfo/linux-pm
--
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2005-12-04 13:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-03 3:15 [RFC] change suspend_finish order slightly Shaohua Li
2005-12-02 20:33 ` Patrick Mochel
2005-12-04 13:55 ` Nigel Cunningham [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-12-05 23:09 Li, Shaohua
2005-12-06 1:36 ` Nigel Cunningham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1133704474.5993.14.camel@laptop.cunninghams \
--to=ncunningham@cyclades.com \
--cc=linux-pm@lists.osdl.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox