/sys/power/state contents

/sys/power/state contents

[Johannes Berg]

[-- Attachment #1.1: Type: text/plain, Size: 290 bytes --]

Why does it say:
 *      show() returns what states are supported, which is hard-coded to
 *      'standby' (Power-On Suspend), 'mem' (Suspend-to-RAM), and
 *      'disk' (Suspend-to-Disk).

and not use the ->valid call to limit what is displayed to what can be
entered?

johannes

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 793 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: /sys/power/state contents

[David Brownell]

[-- Attachment #1: Type: text/plain, Size: 407 bytes --]

On Saturday 29 April 2006 1:44 am, Johannes Berg wrote:
> Why does it say:
>  *      show() returns what states are supported, which is hard-coded to
>  *      'standby' (Power-On Suspend), 'mem' (Suspend-to-RAM), and
>  *      'disk' (Suspend-to-Disk).
> 
> and not use the ->valid call to limit what is displayed to what can be
> entered?

You mean, exactly like the valid_state() function already does??

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: /sys/power/state contents

[Johannes Berg]

[-- Attachment #1.1: Type: text/plain, Size: 306 bytes --]

On Mon, 2006-05-01 at 15:31 -0700, David Brownell wrote:
> > and not use the ->valid call to limit what is displayed to what can be
> > entered?
> 
> You mean, exactly like the valid_state() function already does??

Eh, my apologies. I had indeed missed the call in the if there. Sorry.

johannes

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 793 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: /sys/power/state contents

[Johannes Berg]

[-- Attachment #1.1: Type: text/plain, Size: 478 bytes --]

On Mon, 2006-05-01 at 15:31 -0700, David Brownell wrote:

> You mean, exactly like the valid_state() function already does??

Which actually opens up another question. Why is the default 1 instead
of 0? If an arch doesn't have any callbacks, why announce that it can do
it? It would seem more sensible to me to force an arch that wants to
support this to also have a valid call in order to announce it. Not that
it actually will work, but why even show it?

johannes

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 793 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: /sys/power/state contents

[Pavel Machek]

On Út 02-05-06 11:07:36, Johannes Berg wrote:
> On Mon, 2006-05-01 at 15:31 -0700, David Brownell wrote:
> 
> > You mean, exactly like the valid_state() function already does??
> 
> Which actually opens up another question. Why is the default 1 instead
> of 0? If an arch doesn't have any callbacks, why announce that it can do
> it? It would seem more sensible to me to force an arch that wants to
> support this to also have a valid call in order to announce it. Not that
> it actually will work, but why even show it?

Historical reasons.
								Pavel

-- 
Thanks for all the (sleeping) penguins.