Re: [PATCH 2/2] Fix console handling during suspend/resume

Greg KH
2006-06-29T03:09:23Z

On Wed, Jun 28, 2006 at 05:48:36PM -0700, Linus Torvalds wrote:
>
> I still want the individual drivers be able to split up their high-level
> functions ("device discovery/recovery behind this bus device") from their
> low-level functions ("power on the bus device"), exactly so that we can
> suspend/resume the actual motherboard devices as a totally separate pass
> of suspending/resuming the "rest of the system".
>
> That's what the dpm_active <-> dpm_off <-> dpm_off_irq transitions give
> us in my patch - clearly separate stages for what happens "early", and
> what happens "late".

Yes, I agree, I still like your changes to the core to allow these
different callbacks for different times during the shutdown and resume
proceedure. With my patch I was trying to show that we can handle
subsystems properly now too, with no special cases needed.

Any thoughts as to applying your patch to the tree or not? No objection
from me if you want to.

thanks,

greg k-h