Re: [PATCH 2/2] Fix console handling during suspend/resume

Benjamin Herrenschmidt
2006-06-20T22:47:45Z

> I think the first option is the one that actually works. Right now, to get
> my machine to suspend successfully (with the current broken "suspend
> everything"), I have to turn off the console much much _much_ too early.
> That's what I'm trying to get away from.

I don't think you'll ever get anything stable if you separate freeze and
suspend. I've been implementing working suspend for some time now, and
I've seen it done on other operating systems, and I really think there
is no way out of the very simple fact that suspend is just a superset of
freeze. STD need a freeze pass, STR needs a freeze+suspend pass. You
might want to imagine all sort of reasons why it _would_ be theorically
possible for drivers to recover from STR on resume without having frozen
anything as part of the suspend process but I'm absolutely convinced
that all this will lead to is a suspend process that is even less stable
and more broken than what we have today.

Ben.