Re: [PATCH 2/2] Fix console handling during suspend/resume

Benjamin Herrenschmidt
2006-06-24T00:39:18Z

On Fri, 2006-06-23 at 17:10 -0700, Linus Torvalds wrote:

> It's clear that people who I thought should know better are just too used
> to the status quo, and as such, any change is automatically a bad thing.

What status quo ? I've proposed a set of changes that will help fix
known and identified issues.

I just don't propose to change a whole model that works with one that I
know won't work just for the sake of supposedly improving an
debuggability problem which isn't even there. Debugging suspend() is
easy. Just prevent the console from going to sleep and don't put the
machine in S3 at the ned of the process (just go through the device
model suspend and reusme right away with a hack to not suspend the
console driver and its parents if any).

The problems are in resume most of the time and you aren't fixing any of
this. On the contrary, you will _introduce_ new problems in suspend in
fact if you start going away from the model where suspend has to make
sure we stop processing incoming things. And no, switching interrupts
won't help. It might be a band-aid but it's certainly not a model, and
it's totally useless for runtime PM.

> Me, I don't care. Happily, the whole point of open source is that you can
> change things. So rather than waste time explaining myself to people who
> can't admit that the current situation sucks, I'll just end up doing
> something productive - namely "Just Do It".
>
> I think it's a failure that I have to do things like that myself, but in
> the end, I don't much care. I've fixed up USB and PCMCIA messes for the
> same reasons in the past.
>
> One day maybe it turns out that I'll be wrong. We'll see. I doubt it's
> going to be this time.

So the whole point of open source is that you know better than everybod
who has ever actually worked on the problem & implemented successfully
suspend and resume, and thus will break everything for how many
monthes/year beyond repair just because you are right and everybody else
is wrong ?

Go for it, go. Looks like I won't upgrade the kernel on my latpop for a
while ...

Ben.