Re: [PATCH 2/2] Fix console handling during suspend/resume

Pavel Machek
2006-06-14T23:57:13Z

On St 14-06-06 15:59:00, Linus Torvalds wrote:
>
>
> On Thu, 15 Jun 2006, Pavel Machek wrote:
> >
> > Console subsystem should be stopped when console device is stopped,
> > and restarted when console device is restarted.
>
> There is no "console device".
>
> There are potentially _many_ console devices.

With printks going to all of them?

> And you don't even know which ones they are.
>
> The old setup is BROKEN. The new setup is less so. It really is that
> simple.

I agree that old setup is broken.

> That's not to say that the new setup cannot be improved upon, though. I'm
> just telling you that the old one was not fixable, not the way it thought
> it could do things.

...and yes, queueing the messages is nicer solution then the old one.

My point is that you really want the console enabled in writing phase
of suspend-to-disk. And old setup got that detail right, while new
setup does not.

It should be possible to register console device (whatever it means,
make it /sys/devices/system/printk_console ), and reuse its
suspend/resume routines. That will get "console enabled during write"
for s2disk right, too.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html