Re: [PATCH 2/2] Fix console handling during suspend/resume

Rafael J. Wysocki
2006-06-14T23:02:53Z

On Thursday 15 June 2006 00:44, Pavel Machek wrote:
> On St 14-06-06 15:38:39, Linus Torvalds wrote:
> >
> >
> > On Wed, 14 Jun 2006, Peter Jones wrote:
> >
> > > On Thu, 2006-06-15 at 00:12 +0200, Pavel Machek wrote:
> > > >
> > > > if (network_driver_suspended)
> > > > drop_message_on_the_floor()
> > >
> > > I think we have the same problems with e.g. fbcon .
> >
> > We have the same problem with EVERY SINGLE CONSOLE DEVICE, and we don't
> > always even know which chip is the device (ie the VGA console simply
> > doesn't even care).
> >
> > Which is why my solution really is the right one.
>
> Actually, no, it is not.
>
> It happens to be almost okay for s2ram, but it will mean no messages
> for suspend to disk... and that is bad.
>
> Console subsystem should be stopped when console device is stopped,
> and restarted when console device is restarted.

Well, I don't know. In ususpend we only use pm_prepare/restore_console()
during resume and we can live without that at all.

Greetings,
Rafael