Re: [PATCH 2/2] Fix console handling during suspend/resume

Adam Belay
2006-06-15T00:39:26Z

On Wed, Jun 14, 2006 at 03:37:51PM -0700, Linus Torvalds wrote:
> And btw, the reason it didn't resume originally was because _we_ did
> things wrong. The PCI command word mustn't be writen before the rest of
> the config space has been restored (one of the things I used my debugging
> patches for, until I noticed that -mm had the same fix independently, so
> that's the one that is merged right now ;)

I was hoping to see a more complete fix merged. This patch still writes to a
large number of read-only registers, touches BIST (which can be dangerous on
some hardware), and isn't careful about the initial state of the PCI command
word.

I attempted to rework pci_save/restore_state() a couple weeks ago:
http://marc.theaimsgroup.com/?l=linux-kernel&m=114949711413176&w=2

Any comments would be appreciated.

Thanks,
Adam