Re: [PATCH 2/2] Fix console handling during suspend/resume

Linus Torvalds
2006-06-22T22:31:06Z

On Fri, 23 Jun 2006, Benjamin Herrenschmidt wrote:
>
> The problem is that what you call "controller setup" might well happen
> as part of normal operations of a given device.

Give one _reasonable_ example.

> I think you are trying to change a model that is not broken...

Bzzt. Thank you for playing.

The fact is, this thing has been broken for years. At some point, we have
to just accept the fact that it's not just "drivers". There's something
else that is broken, and I bet it's the model.

The fact that drivers don't get fixed should be a big hint.

And yes, maybe I'm wrong, but even if I am, what have we got to lose?
Nothing. The thing doesn't work reliably now.

And you haven't actually answered any of my fundamental issues, which
boils down to

- debuggability
- not doing five things in the same routine.

but instead you have brought up total red herrings that have nothing to do
with either (including apparently the totally ludicrous claim that it's
"easier" for drivers to have just one complicated function).

Linus