Re: [PATCH 2/2] Fix console handling during suspend/resume

Pavel Machek
2006-06-22T23:31:37Z

Hi!

> > The main reason is the video problem (chips not coming back on resume
> > and needing a POST). This has always been the main issue and that's what
> > is causing STR not to work for a lot of people.
>
> No.
>
> Not for me. Every single time something doesn't work for me, I just plug
> it into the network and try to debug it over the net.

Well, apparently you were the first one to try to use netconsole for
s2ram debugging. Sorry -- we were using regular vgacon.

> > The model does and I think your model would 1- break all existing
> > drivers that got it right since they have to be changed
>
> Actually, it won't break a single driver for STR.
>
> Why? Because if you do it the old way, STR will still happen to work. I'm
> just giving you a separate phase.

Separate phase, that Ben demonstrated is totally useless. How is that
supposed to help?

> So you say. Have you actually ever done anything to make debugging easier?
>
> Nope. In the years I've been frustrated with suspend, nobody has ever done
> anything to this. And now I have to push through changes, just because
> people think that "status quo" is acceptable.

It actually works on a lot of machines. Maybe we are pushing way too
much work to drivers... but that should be solved by providing
subsystem-specific helpers, not by changing the design.

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html