Re: [PATCH 2/2] Fix console handling during suspend/resume

David Brownell
2006-07-09T23:28:28Z

[-- Attachment #1: Type: text/plain, Size: 367 bytes --]

> > > Any thoughts as to applying your patch to the tree or not? No objection
> > > from me if you want to.
> >
> > I've not actually had anybody report any testing success from it ...

Here's a minor fix to Linus' PM API changes: remove some syslog noise,
these messages appear even when they're meaningless. Greg, please add
this to your collection.

- Dave

[-- Attachment #2: linus-pm-fix.patch --]
[-- Type: text/x-diff, Size: 819 bytes --]

Fix a goof in Linus' recent PM API updates: don't emit any messages in the
typical NOP "already suspended it" late suspend case.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>

Index: at91/drivers/base/power/suspend.c
===================================================================
--- at91.orig/drivers/base/power/suspend.c 2006-07-09 13:57:34.000000000 -0700
+++ at91/drivers/base/power/suspend.c 2006-07-09 13:57:34.000000000 -0700
@@ -102,11 +102,6 @@ static int suspend_device_late(struct de
{
int error = 0;

- if (dev->power.power_state.event) {
- dev_dbg(dev, "PM: suspend_late %d-->%d\n",
- dev->power.power_state.event, state.event);
- }
-
if (dev->bus && dev->bus->suspend_late && !dev->power.power_state.event) {
dev_dbg(dev, "LATE %s%s\n",
suspend_verb(state.event),

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]