From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH v2] cpufreq: powernv: Replacing pstate_id with frequency table index Date: Sat, 16 Jul 2016 03:02:36 +0200 Message-ID: <11588667.R3ZLC4VYDO@vostro.rjw.lan> References: <1467267787-2622-1-git-send-email-akshay.adiga@linux.vnet.ibm.com> <20160711184753.GD4695@ubuntu> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20160711184753.GD4695@ubuntu> Sender: linux-kernel-owner@vger.kernel.org To: Viresh Kumar , Akshay Adiga Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, ego@linux.vnet.ibm.com, paulus@ozlabs.org, mpe@ellerman.id.au List-Id: linux-pm@vger.kernel.org On Monday, July 11, 2016 11:47:53 AM Viresh Kumar wrote: > On 30-06-16, 11:53, Akshay Adiga wrote: > > Refactoring code to use frequency table index instead of pstate_id. > > This abstraction will make the code independent of the pstate values. > > > > - No functional changes > > - The highest frequency is at frequency table index 0 and the frequency > > decreases as the index increases. > > - Macros pstates_to_idx() and idx_to_pstate() can be used for conversion > > between pstate_id and index. > > - powernv_pstate_info now contains frequency table index to min, max and > > nominal frequency (instead of pstate_ids) > > - global_pstate_info new stores index values instead pstate ids. > > - variables renamed as *_idx which now store index instead of pstate > > > > Signed-off-by: Akshay Adiga > > Reviewed-by: Gautham R. Shenoy > > --- > > Changes from v1: > > - changed macro names from get_pstate()/ get_index() to > > idx_to_pstate()/ pstate_to_idx() > > - Renamed variables that store index instead of pstate_id to *_idx > > - Retained previous printk's > > > > v1 : http://marc.info/?l=linux-pm&m=146677701501225&w=1 > > > > drivers/cpufreq/powernv-cpufreq.c | 177 ++++++++++++++++++++++---------------- > > 1 file changed, 102 insertions(+), 75 deletions(-) > > Haven't done in-depth review, but I trust that Gautham has done it :) > > Acked-by: Viresh Kumar Patch applied, thanks!