public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
* Re: suspending to disk on FC6 not working
@ 2006-09-29 22:55 Pallipadi, Venkatesh
  2006-10-01  2:49 ` Louis Garcia
  0 siblings, 1 reply; 39+ messages in thread
From: Pallipadi, Venkatesh @ 2006-09-29 22:55 UTC (permalink / raw)
  To: Dave Jones; +Cc: linux-pm, Pavel Machek

 

>-----Original Message-----
>From: Dave Jones [mailto:davej@redhat.com] 
>Sent: Friday, September 29, 2006 3:26 PM
>To: Pallipadi, Venkatesh
>Cc: Louis Garcia; Pavel Machek; linux-pm@lists.osdl.org
>Subject: Re: [linux-pm] suspending to disk on FC6 not working
>
>On Fri, Sep 29, 2006 at 02:35:43PM -0700, Pallipadi, Venkatesh wrote:
> 
> > cpufreq_cpu_data[] = NULL; only happens when acpi_cpufreq 
>driver init
> > fails;
> > Looks like acpi_cpufreq driver init is failing at some point in this
> > case and the driver is staying loaded after that failure. 
>That in turn
> > seems similar to one other bug I saw recently.
>
>Ah, that was because it was marked CPUFREQ_STICKY in 2.6.18.
>That was added to work around another problem : If it was 
>built modular,
>a modprobe acpi-cpufreq would be really noisy when it get an -ENODEV
>

That's it.. This issue seems to be a side effect of that patch...

Louis: After normal boot of 2.6.18, if you are not seeing the directory
/sys/devices/system/cpu/cpu0/cpufreq

Then try reverting this patch
http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=c
ommit;h=911cb74bb9e77e40749abc2fca6fe74d87d940f3

and then check whether the suspend resume issue goes away. 

Thanks,
Venki

^ permalink raw reply	[flat|nested] 39+ messages in thread
* Re: suspending to disk on FC6 not working
@ 2006-10-01  5:07 Pallipadi, Venkatesh
  2006-10-01  5:22 ` Dave Jones
  2006-10-01  5:22 ` Louis Garcia
  0 siblings, 2 replies; 39+ messages in thread
From: Pallipadi, Venkatesh @ 2006-10-01  5:07 UTC (permalink / raw)
  To: Louis Garcia, Dave Jones; +Cc: linux-pm, Pavel Machek

 

>-----Original Message-----
>From: Louis Garcia [mailto:louisg00@bellsouth.net] 
>Sent: Saturday, September 30, 2006 10:00 PM
>To: Dave Jones
>Cc: Pallipadi, Venkatesh; Pavel Machek; linux-pm@lists.osdl.org
>Subject: Re: [linux-pm] suspending to disk on FC6 not working
>
>On Sat, 2006-09-30 at 23:21 -0400, Dave Jones wrote:
>> On Sat, Sep 30, 2006 at 10:49:42PM -0400, Louis Garcia wrote:
>>  > On Fri, 2006-09-29 at 15:55 -0700, Pallipadi, Venkatesh wrote:
>>  > > That's it.. This issue seems to be a side effect of 
>that patch...
>>  > > 
>>  > > Louis: After normal boot of 2.6.18, if you are not 
>seeing the directory
>>  > > /sys/devices/system/cpu/cpu0/cpufreq
>>  > > 
>>  > > Then try reverting this patch
>>  > > 
>http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.
>6.git;a=c
>>  > > ommit;h=911cb74bb9e77e40749abc2fca6fe74d87d940f3
>>  > > 
>>  > > and then check whether the suspend resume issue goes away. 
>>  > > 
>>  > > Thanks,
>>  > > Venki
>>  > 
>>  > I reverted this patch and my suspend issue is gone. Though the
>>  > directory /sys/devices/system/cpu/cpu0/cpufreq is non 
>existent, with or
>>  > without this patch.
>> 
>> Ok, I've backed that out in cpufreq.git, it'll go along to 
>Linus soon.
>> If you build acpi-cpufreq as a module, and you modprobe acpi-cpufreq,
>> does it fail silently ? Or does it revert us back to the behaviour
>> where it's noisy again?
>> 
>> 	Dave
>
>I had not noticed it was not loaded. This maybe a bigger problem. With
>the latest FC6 kernel this module gets loaded and thus suspend fails. I
>rebuilt the same kernel but plopped this patch in. The module does not
>want to load:
>
># /sbin/modprobe acpi-cpufreq
>FATAL: Error inserting acpi_cpufreq
>(/lib/modules/2.6.18-1.2708.cpufreq/kernel/arch/i386/kernel/cpu
>/cpufreq/acpi-cpufreq.ko): No such device
>
>This is why suspend works. But now this module won't load.
>

The module was not working on your laptop even when suspend was failing.
That is what the absence of /sys.../cpufreq says. If this module was
working for you earlier and stopped working recently or even otherwise
both this and speedstep-centrino does not work on your platform, that is
a separate issue. Was this module working and cpufreq supported on your
system with any earlier kernels?

Thanks,
Venki

^ permalink raw reply	[flat|nested] 39+ messages in thread
* Re: suspending to disk on FC6 not working
@ 2006-09-29 22:23 Pallipadi, Venkatesh
  0 siblings, 0 replies; 39+ messages in thread
From: Pallipadi, Venkatesh @ 2006-09-29 22:23 UTC (permalink / raw)
  To: Pavel Machek; +Cc: linux-pm

 

>-----Original Message-----
>From: Pavel Machek [mailto:pavel@ucw.cz] 
>Sent: Friday, September 29, 2006 3:15 PM
>To: Pallipadi, Venkatesh
>Cc: Dave Jones; Louis Garcia; linux-pm@lists.osdl.org
>Subject: Re: [linux-pm] suspending to disk on FC6 not working
>
>Hi!
>
>> > > Could not power down device &q->lock: error -22
>> > > Some devices failed to power down, aborting suspend
>> >
>> >Ok, I'm not quite sure how we got into this state.  Venkatesh, 
>> >any ideas ?
>> >acpi-cpufreq got quite a few changes between .17 and .18, 
>including the
>> >two large 'P-state coordination' change.
>> >
>> >Louis, I'm attaching two smaller changes that went into .18.
>> >Can you apply those with -R, and see if either of those makes 
>> >a difference?
>> 
>> cpufreq_cpu_data[] = NULL; only happens when acpi_cpufreq driver init
>> fails;
>> Looks like acpi_cpufreq driver init is failing at some point in this
>> case and the driver is staying loaded after that failure. 
>That in turn
>> seems similar to one other bug I saw recently.
>
>Uh, if acpi_cpufreq is built-in... you can't unload it when init
>fails, so you need to handle that somehow...?
>

Sorry. I meant unregistering with cpufreq. When acpi-cpufreq fails, it
should be unregistered from cpufreq and either cpufreq should look for
some other driver that may work or cpufreq should mark that there is no
driver registered. I am looking at the acpi-cpufreq changes that might
have resulted in this and havent found anything yet...

Thanks,
Venki

^ permalink raw reply	[flat|nested] 39+ messages in thread
* Re: suspending to disk on FC6 not working
@ 2006-09-29 21:35 Pallipadi, Venkatesh
  2006-09-29 22:14 ` Pavel Machek
  2006-09-29 22:25 ` Dave Jones
  0 siblings, 2 replies; 39+ messages in thread
From: Pallipadi, Venkatesh @ 2006-09-29 21:35 UTC (permalink / raw)
  To: Dave Jones, Louis Garcia; +Cc: linux-pm, Pavel Machek


>-----Original Message-----
>From: Dave Jones [mailto:davej@redhat.com] 
>Sent: Friday, September 29, 2006 1:54 PM
>To: Louis Garcia
>Cc: Pallipadi, Venkatesh; Pavel Machek; linux-pm@lists.osdl.org
>Subject: Re: [linux-pm] suspending to disk on FC6 not working
>
>On Wed, Sep 27, 2006 at 02:55:29AM -0400, Louis Garcia wrote:
>
> > >  >  > > > > goes to the 2nd runlevel (ie. without network 
>servers and X).  Then log in
> > >  >  > > > > as root, do "echo 8 > /proc/sys/kernel/printk" and
> > >  >  > > > > "echo disk > /sys/power/state".  The system 
>should suspend to disk and power
> > >  >  > > > > off the machine.  If it doesn't do that (ie. 
>if it returns to the shell
> > >  >  > > > > immediately), please do "dmesg > dmesg.log" 
>and send the dmesg.log file
> > >  >  > > > > to me.
> > >  >  > > > 
> > >  >  > > > The system didn't power off, it returned to the 
>shell. I attached dmesg.
> > >  >  > > 
> > >  >  > > Pavel, it looks like we have a problem with the 
>CPU suspend on this box:
> > >  >  > > 
> > >  >  > > acpi acpi: freeze
> > >  >  > > PM: snapshotting memory.
> > >  >  > > Class driver suspend failed for cpu0
> > >  >  > > Could not power down device &q->lock: error -22
> > >  >  > > Some devices failed to power down, aborting suspend
> > >  >  > > acpi acpi: resuming
> > >  >  > 
> > >  >  > That looks like cpufreq/acpi, no?
> > >  > 
> > >  > Looking at drivers/cpufreq/cpufreq.c:cpufreq_suspend(),
> > >  > There's only two ways we can fail that function. In one way,
> > >  > we'll see a printk, and the other we silently -EINVAL.
> > >  > Given the log doesn't show the printk, we must be 
>failing here..
> > >  > 
> > >  >     cpu_policy = cpufreq_cpu_get(cpu);
> > >  >     if (!cpu_policy)
> > >  >         return -EINVAL;
> > >  > 
> > >  > cpufreq_cpu_get has a number of potential ways it 
>could fail however,
> > >  > and isn't very chatty about failing, so we've no real idea
> > >  > what's falling apart there.
> > > 
> > > This patch might give us some more clues.
> > >  
> > > --- 1/drivers/cpufreq/cpufreq.c	2006-09-24 
>00:26:42.000000000 -0400
> > > +++ 2/drivers/cpufreq/cpufreq.c	2006-09-26 
>22:48:49.000000000 -0400
> > > @@ -63,27 +63,36 @@ struct cpufreq_policy *cpufreq_cpu_get(u
> > >  	struct cpufreq_policy *data;
> > >  	unsigned long flags;
> > >  
> > > -	if (cpu >= NR_CPUS)
> > > +	if (cpu >= NR_CPUS) {
> > > +		printk(KERN_DEBUG "cpufreq_cpu_get failed 
>(!>=NR_CPUS)\n");
> > >  		goto err_out;
> > > +	}
> > >  
> > >  	/* get the cpufreq driver */
> > >  	spin_lock_irqsave(&cpufreq_driver_lock, flags);
> > >  
> > > -	if (!cpufreq_driver)
> > > +	if (!cpufreq_driver) {
> > > +		printk(KERN_DEBUG "cpufreq_cpu_get failed (!driver)\n");
> > >  		goto err_out_unlock;
> > > +	}
> > >  
> > > -	if (!try_module_get(cpufreq_driver->owner))
> > > +	if (!try_module_get(cpufreq_driver->owner)) {
> > > +		printk(KERN_DEBUG "cpufreq_cpu_get failed 
>(!try_module_get)\n");
> > >  		goto err_out_unlock;
> > > -
> > > +	}
> > >  
> > >  	/* get the CPU */
> > >  	data = cpufreq_cpu_data[cpu];
> > >  
> > > -	if (!data)
> > > +	if (!data) {
> > > +		printk(KERN_DEBUG "cpufreq_cpu_get failed (!data)\n");
> > >  		goto err_out_put_module;
> > > +	}
> > >  
> > > -	if (!kobject_get(&data->kobj))
> > > +	if (!kobject_get(&data->kobj)) {
> > > +		printk(KERN_DEBUG "cpufreq_cpu_get failed 
>(!kobject_get)\n");
> > >  		goto err_out_put_module;
> > > +	}
> > >  
> > >  	spin_unlock_irqrestore(&cpufreq_driver_lock, flags);
> > >  	return data;
> > >
> > ... 
> > PM: snapshotting memory.
> > cpufreq_cpu_get failed (!data)
> > Class driver suspend failed for cpu0
> > Could not power down device &q->lock: error -22
> > Some devices failed to power down, aborting suspend
>
>Ok, I'm not quite sure how we got into this state.  Venkatesh, 
>any ideas ?
>acpi-cpufreq got quite a few changes between .17 and .18, including the
>two large 'P-state coordination' change.
>
>Louis, I'm attaching two smaller changes that went into .18.
>Can you apply those with -R, and see if either of those makes 
>a difference?
>
>	Dave
>

cpufreq_cpu_data[] = NULL; only happens when acpi_cpufreq driver init
fails;
Looks like acpi_cpufreq driver init is failing at some point in this
case and the driver is staying loaded after that failure. That in turn
seems similar to one other bug I saw recently.

Louis, Can you check whether cpufreq is really working In you case. Boot
normally and before you try suspending, just see whether
/sys/devices/system/cpu/cpu0/cpufreq exists and if it does, cat
everything in that directory.

Thanks,
Venki 

^ permalink raw reply	[flat|nested] 39+ messages in thread
* suspending to disk on FC6 not working
@ 2006-09-24 22:55 Louis Garcia
  2006-09-25  7:16 ` Rafael J. Wysocki
  0 siblings, 1 reply; 39+ messages in thread
From: Louis Garcia @ 2006-09-24 22:55 UTC (permalink / raw)
  To: linux-pm

When I first installed FC6 test 2 suspend to disk worked on my box which
is a Dell dimension 8200 (P4). During the kernel-2.6.17-xxx updates this
has stopped working. Now kernel-2.6.18 has come out and I'm having the
same problems. I have tried to get this resolved on there mailing list
but it's not high on there things todo. I would like to debug suspend to
see what is happening. What is the proper way to do this? Has this been
discussed before? Is there a separate mailing-list for suspend?

-Louis

^ permalink raw reply	[flat|nested] 39+ messages in thread

end of thread, other threads:[~2006-10-01 18:56 UTC | newest]

Thread overview: 39+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-29 22:55 suspending to disk on FC6 not working Pallipadi, Venkatesh
2006-10-01  2:49 ` Louis Garcia
2006-10-01  3:21   ` Dave Jones
2006-10-01  5:00     ` Louis Garcia
2006-10-01  5:05       ` Dave Jones
2006-10-01  5:30         ` Pavel Machek
  -- strict thread matches above, loose matches on Subject: below --
2006-10-01  5:07 Pallipadi, Venkatesh
2006-10-01  5:22 ` Dave Jones
2006-10-01 12:28   ` Rafael J. Wysocki
2006-10-01 18:36     ` Dave Jones
2006-10-01 18:38       ` Pavel Machek
2006-10-01 18:56         ` Dave Jones
2006-10-01  5:22 ` Louis Garcia
2006-09-29 22:23 Pallipadi, Venkatesh
2006-09-29 21:35 Pallipadi, Venkatesh
2006-09-29 22:14 ` Pavel Machek
2006-09-29 22:25 ` Dave Jones
2006-09-24 22:55 Louis Garcia
2006-09-25  7:16 ` Rafael J. Wysocki
2006-09-25 17:10   ` Louis Garcia
2006-09-25 18:43     ` Rafael J. Wysocki
2006-09-25 19:34       ` Louis Garcia
2006-09-25 20:15         ` Rafael J. Wysocki
2006-09-25 23:04           ` Louis Garcia
2006-09-26 10:00             ` Rafael J. Wysocki
2006-09-26 21:47               ` Louis Garcia
2006-09-26 22:01                 ` Rafael J. Wysocki
2006-09-26 22:15                   ` Pavel Machek
2006-09-26 22:26                     ` Rafael J. Wysocki
2006-09-26 22:39                       ` Louis Garcia
2006-09-26 22:45                         ` Pavel Machek
2006-09-26 22:54                           ` Rafael J. Wysocki
2006-09-26 22:58                             ` Pavel Machek
2006-09-26 23:09                               ` Louis Garcia
2006-09-26 23:12                                 ` Pavel Machek
2006-09-27  2:36                     ` Dave Jones
2006-09-27  2:51                       ` Dave Jones
2006-09-27  6:55                         ` Louis Garcia
2006-09-29 20:54                           ` Dave Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox