From: Nigel Cunningham <ncunningham@linuxmail.org>
To: Linux PM <linux-pm@osdl.org>, LKML <linux-kernel@vger.kernel.org>,
suspend2-devel <suspend2-devel@lists.suspend2.net>
Subject: [PATCH] Quieten freezer if !CONFIG_PM_DEBUG.
Date: Sat, 21 Oct 2006 22:22:43 +1000 [thread overview]
Message-ID: <1161433364.7644.9.camel@nigel.suspend2.net> (raw)
The freezing of processes is currently very noisy. This patch makes the
noise dependant upon CONFIG_PM_DEBUG.
Prepared against current git.
Signed-off-by: Nigel Cunningham <nigel@suspend2.net>
diff --git a/kernel/power/process.c b/kernel/power/process.c
index 29be608..6829612 100644
--- a/kernel/power/process.c
+++ b/kernel/power/process.c
@@ -15,6 +15,12 @@ #include <linux/module.h>
#include <linux/syscalls.h>
#include <linux/freezer.h>
+#ifdef CONFIG_PM_DEBUG
+#define freezer_message(msg, a...) do { printk(msg, ##a); } while(0)
+#else
+#define freezer_message(msg, a...) do { } while(0)
+#endif
+
/*
* Timeout for stopping processes
*/
@@ -40,7 +46,7 @@ void refrigerator(void)
long save;
save = current->state;
pr_debug("%s entered refrigerator\n", current->comm);
- printk("=");
+ freezer_message("=");
frozen_process(current);
spin_lock_irq(¤t->sighand->siglock);
@@ -87,7 +93,7 @@ int freeze_processes(void)
unsigned long start_time;
struct task_struct *g, *p;
- printk( "Stopping tasks: " );
+ freezer_message( "Stopping tasks: " );
start_time = jiffies;
user_frozen = 0;
do {
@@ -135,7 +141,7 @@ int freeze_processes(void)
* but it cleans up leftover PF_FREEZE requests.
*/
if (todo) {
- printk( "\n" );
+ freezer_message( "\n" );
printk(KERN_ERR " stopping tasks timed out "
"after %d seconds (%d tasks remaining):\n",
TIMEOUT / HZ, todo);
@@ -149,7 +155,7 @@ int freeze_processes(void)
return todo;
}
- printk( "|\n" );
+ freezer_message( "|\n" );
BUG_ON(in_atomic());
return 0;
}
@@ -158,18 +164,18 @@ void thaw_processes(void)
{
struct task_struct *g, *p;
- printk( "Restarting tasks..." );
+ freezer_message( "Restarting tasks..." );
read_lock(&tasklist_lock);
do_each_thread(g, p) {
if (!freezeable(p))
continue;
if (!thaw_process(p))
- printk(KERN_INFO " Strange, %s not stopped\n", p->comm );
+ freezer_message(KERN_INFO " Strange, %s not stopped\n", p->comm );
} while_each_thread(g, p);
read_unlock(&tasklist_lock);
schedule();
- printk( " done\n" );
+ freezer_message( " done\n" );
}
EXPORT_SYMBOL(refrigerator);
next reply other threads:[~2006-10-21 12:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-21 12:22 Nigel Cunningham [this message]
2006-10-21 12:44 ` [PATCH] Quieten freezer if !CONFIG_PM_DEBUG Pavel Machek
2006-10-21 14:01 ` Rafael J. Wysocki
2006-10-21 22:32 ` Nigel Cunningham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1161433364.7644.9.camel@nigel.suspend2.net \
--to=ncunningham@linuxmail.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@osdl.org \
--cc=suspend2-devel@lists.suspend2.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox