From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nigel Cunningham Subject: Re: [PATCH] Add include/linux/freezer.h and move definitions from sched.h Date: Sun, 22 Oct 2006 08:27:21 +1000 Message-ID: <1161469641.17061.18.camel@nigel.suspend2.net> References: <1161433266.7644.7.camel@nigel.suspend2.net> <200610211541.19050.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200610211541.19050.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org To: "Rafael J. Wysocki" Cc: LKML , Linux PM , suspend2-devel List-Id: linux-pm@vger.kernel.org Hi. On Sat, 2006-10-21 at 15:41 +0200, Rafael J. Wysocki wrote: > On Saturday, 21 October 2006 14:21, Nigel Cunningham wrote: > > Move process freezing functions from include/linux/sched.h to freezer.h, > > Hm, I'd rather move them to suspend.h. Is there any reason for introducing > yet another header file? Suspend.h sounds reasonable. I picked freezer.h because I thought it made the purpose of the #include simple and crystal clear, and doesn't pull in other dependencies (my freezer.h depends on nothing else, where as suspend.h already depends on: #if defined(CONFIG_X86) || defined(CONFIG_FRV) || defined(CONFIG_PPC32) #include #endif #include #include #include #include That said, suspend.h isn't anything like sched.h itself :) Nigel