public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Pavel Machek <pavel@suse.cz>
Cc: linuxppc-dev@ozlabs.org, Torrance <torrance123@gmail.com>,
	Michael Buesch <mb@bu3sch.de>,
	linux-pm@lists.osdl.org
Subject: Re: [linux-pm] [RFC 1/3] support powermac G5 CPU hotplug
Date: Tue, 12 Dec 2006 14:47:17 +0100	[thread overview]
Message-ID: <1165931237.22338.36.camel@johannes.berg> (raw)
In-Reply-To: <1165929483.22338.18.camel@johannes.berg>


[-- Attachment #1.1: Type: text/plain, Size: 669 bytes --]

On Tue, 2006-12-12 at 14:18 +0100, Johannes Berg wrote:

> > ?? Context for downing cpu should better be well-defined. Just do this
> > in cpu_die if it is really required.
> 
> It is actually required but I'm not exactly sure why. When I don't do
> this, I end up with preempt_count() 0x100000 (IIRC, notes not here at
                                      ^^^^^^^^ typo, should be 0x10000
> the moment).
> 
> I think this is because the suspend code has interrupts disabled already
> when downing the CPUs.

Also, the /sys/devices/system/cpu/cpuN/online thing doesn't disable
interrupts before downing the CPU thus that works without this.

johannes

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

[-- Attachment #2: Type: text/plain, Size: 146 bytes --]

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

  reply	other threads:[~2006-12-12 13:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20061211230208.526233000@sipsolutions.net>
2006-12-11 23:02 ` [RFC 1/3] support powermac G5 CPU hotplug Johannes Berg
2006-12-11 23:02 ` Johannes Berg
2006-12-11 23:02 ` [RFC 2/3] windfarm: dont die on suspend thread signal Johannes Berg
2006-12-11 23:02 ` Johannes Berg
2006-12-11 23:02 ` [RFC 3/3] suspend to disk on powermac G5 Johannes Berg
2006-12-11 23:02 ` Johannes Berg
2006-12-12 12:21 ` [RFC 0/3] experimental G5 powermac suspend implementation Johannes Berg
2006-12-12 13:22   ` [linux-pm] " Pavel Machek
2006-12-12 13:36     ` Johannes Berg
2006-12-12 14:07       ` [linux-pm] " Johannes Berg
2006-12-12 17:34         ` Gabriel Paubert
2006-12-13 12:37           ` Johannes Berg
     [not found] ` <20061211230754.380263000@sipsolutions.net>
2006-12-12 13:09   ` [RFC 1/3] support powermac G5 CPU hotplug Pavel Machek
2006-12-12 13:18     ` [linux-pm] " Johannes Berg
2006-12-12 13:47       ` Johannes Berg [this message]
2006-12-13 13:20     ` Johannes Berg
     [not found] ` <20061211230754.679589000@sipsolutions.net>
2006-12-12 13:10   ` [RFC 2/3] windfarm: dont die on suspend thread signal Pavel Machek
2007-01-24  6:32   ` Benjamin Herrenschmidt
     [not found] ` <20061211230754.979775000@sipsolutions.net>
2006-12-12 13:20   ` [linux-pm] [RFC 3/3] suspend to disk on powermac G5 Pavel Machek
2006-12-12 13:33     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1165931237.22338.36.camel@johannes.berg \
    --to=johannes@sipsolutions.net \
    --cc=linux-pm@lists.osdl.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mb@bu3sch.de \
    --cc=pavel@suse.cz \
    --cc=torrance123@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox