From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCH 13/12] mpic: add affinity callback for IPI "chip" Date: Fri, 09 Feb 2007 08:14:12 +1100 Message-ID: <1170969252.2620.335.camel@localhost.localdomain> References: <20070207124536.963531000@sipsolutions.net> <1170940611.4385.56.camel@johannes.berg> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1170940611.4385.56.camel@johannes.berg> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.osdl.org Errors-To: linux-pm-bounces@lists.osdl.org To: Johannes Berg Cc: linuxppc-dev@ozlabs.org, linux-pm@lists.osdl.org List-Id: linux-pm@vger.kernel.org On Thu, 2007-02-08 at 14:16 +0100, Johannes Berg wrote: > This patch adds a dummy affinity callback for the IPI "chip" to avoid > getting a warning ("Cannot set affinity for irq 251") when taking a > CPU offline via sysfs or during suspend. Wouldn't be a better option to make sure they have IRQF_PERCPU set and that we don't do the affinity thing on interrupts with that flag when = offlining a CPU ? Ben. > Signed-off-by: Johannes Berg > = > --- linux-2.6-git.orig/arch/powerpc/sysdev/mpic.c 2007-02-08 00:19:46.105= 926568 +0100 > +++ linux-2.6-git/arch/powerpc/sysdev/mpic.c 2007-02-08 00:22:31.81092656= 8 +0100 > @@ -700,6 +700,12 @@ static void mpic_end_ipi(unsigned int ir > mpic_eoi(mpic); > } > = > +static void mpic_set_ipi_affinity(unsigned int irq, cpumask_t cpumask) > +{ > + /* we can't set affinity but also don't need to since we only > + * send IPIs to online CPUs */ > +} > + > #endif /* CONFIG_SMP */ > = > static void mpic_set_affinity(unsigned int irq, cpumask_t cpumask) > @@ -788,6 +794,7 @@ static struct irq_chip mpic_ipi_chip =3D { > .mask =3D mpic_mask_ipi, > .unmask =3D mpic_unmask_ipi, > .eoi =3D mpic_end_ipi, > + .set_affinity =3D mpic_set_ipi_affinity, > }; > #endif /* CONFIG_SMP */ > =