From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org,
Johannes Berg <johannes@sipsolutions.net>,
linux-pm@lists.osdl.org
Subject: Re: [PATCH 02/12] powermac: support G5 CPU hotplug
Date: Fri, 09 Feb 2007 09:33:32 +1100 [thread overview]
Message-ID: <1170974012.2620.384.camel@localhost.localdomain> (raw)
In-Reply-To: <17867.40281.175422.116673@cargo.ozlabs.ibm.com>
> Are you sure this is necessary? IIRC, the if (!cpu_is_offline(cpu)) a
> little bit further down is there to cope with this exact situation.
> And cpu hotplug already works on G4 SMP powermacs, where we can't
> physically remove the cpu either - we just put it into sleep mode with
> interrupts disabled, which is what we would be doing on a G5 powermac
> also.
I've always had doubts about wether SLEEP with EE off was legal and
wouldn't actually still go out of sleep when getting an interrupt... In
that case, at least on CPUs where the DEC acts "level" triggered, we
need to at least reset the DEC to some sane value.
Ben.
next prev parent reply other threads:[~2007-02-08 22:33 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-07 12:45 [PATCH 00/12] powerpc/powermac power management patches Johannes Berg
2007-02-07 12:45 ` [PATCH 01/12] powerpc: MPIC sys_device & suspend/resume Johannes Berg
2007-02-07 12:45 ` [PATCH 02/12] powermac: support G5 CPU hotplug Johannes Berg
2007-02-08 13:14 ` Johannes Berg
2007-02-08 13:28 ` Johannes Berg
2007-02-08 15:38 ` Johannes Berg
2007-02-08 21:59 ` Paul Mackerras
2007-02-08 22:33 ` Benjamin Herrenschmidt [this message]
2007-02-09 15:39 ` Johannes Berg
2007-02-08 22:24 ` Benjamin Herrenschmidt
2007-02-08 22:24 ` Benjamin Herrenschmidt
2007-02-09 15:36 ` Johannes Berg
2007-02-12 15:15 ` Johannes Berg
2007-02-15 3:44 ` Paul Mackerras
2007-02-15 15:08 ` Johannes Berg
2007-02-15 19:43 ` Johannes Berg
2007-02-14 14:45 ` Pavel Machek
2007-02-14 19:11 ` Johannes Berg
2007-02-14 21:27 ` Benjamin Herrenschmidt
2007-02-07 12:45 ` [PATCH 03/12] powerpc: dart iommu suspend Johannes Berg
2007-02-07 12:45 ` [PATCH 04/12] powerpc: mark pages that dont exist as Nosave Johannes Berg
2007-02-07 12:45 ` [PATCH 05/12] power management: no valid states w/o pm_ops + docs Johannes Berg
2007-02-13 12:12 ` Pavel Machek
2007-02-13 16:08 ` Johannes Berg
2007-02-13 16:14 ` Pavel Machek
2007-02-07 12:45 ` [PATCH 06/12] powerpc: fix suspend states again Johannes Berg
2007-02-07 12:45 ` [PATCH 07/12] powermac: suspend to disk on G5 Johannes Berg
2007-02-07 12:45 ` [PATCH 08/12] powermac: fix G5-cpufreq for cpu on/offline Johannes Berg
2007-02-07 12:45 ` [PATCH 09/12] powerpc: remove bogus comment about page_is_ram Johannes Berg
2007-02-07 12:45 ` [PATCH 10/12] powerpc: remove unneeded exports in mem.c Johannes Berg
2007-02-08 4:25 ` Paul Mackerras
2007-02-08 13:10 ` Johannes Berg
2007-02-08 13:27 ` [PATCH 10/12] powerpc: remove unneeded page_is_ram export Johannes Berg
2007-02-07 12:45 ` [PATCH 11/12] powermac: disallow pmu sleep notifiers from aborting sleep Johannes Berg
2007-02-07 22:52 ` Andreas Schwab
2007-02-08 13:08 ` Johannes Berg
2007-02-08 13:16 ` Johannes Berg
2007-02-07 12:45 ` [PATCH 12/12] powermac: proper sleep management Johannes Berg
2007-02-08 13:16 ` [PATCH 13/12] mpic: add affinity callback for IPI "chip" Johannes Berg
2007-02-08 21:14 ` Benjamin Herrenschmidt
2007-02-09 15:41 ` Johannes Berg
2007-02-12 15:20 ` [PATCH 13/12] mpic: set IPIs to be per-CPU Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1170974012.2620.384.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=johannes@sipsolutions.net \
--cc=linux-pm@lists.osdl.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox