From: Nigel Cunningham <nigel@nigel.suspend2.net>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@lists.osdl.org, jgarzik@pobox.com, stable@kernel.org,
Alan <alan@lxorguk.ukuu.org.uk>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Subject: Re: [PATCH 2/2 -stable] libata: add missing CONFIG_PM in LLDs
Date: Sat, 03 Mar 2007 11:18:14 +1100 [thread overview]
Message-ID: <1172881095.18544.108.camel@nigel.suspend2.net> (raw)
In-Reply-To: <20070302084649.GO20322@htj.dyndns.org>
Hi.
On Fri, 2007-03-02 at 17:46 +0900, Tejun Heo wrote:
> Add missing #ifdef CONFIG_PM conditionals around all PM related parts
> in libata LLDs.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> drivers/ata/ahci.c | 14 ++++++++++++++
> drivers/ata/ata_generic.c | 4 ++++
> drivers/ata/ata_piix.c | 4 ++++
> drivers/ata/pata_ali.c | 6 ++++++
> drivers/ata/pata_amd.c | 6 ++++++
> drivers/ata/pata_atiixp.c | 4 ++++
> drivers/ata/pata_cmd64x.c | 6 ++++++
> drivers/ata/pata_cs5520.c | 7 +++++++
> drivers/ata/pata_cs5530.c | 6 ++++++
> drivers/ata/pata_cs5535.c | 4 ++++
> drivers/ata/pata_cypress.c | 4 ++++
> drivers/ata/pata_efar.c | 4 ++++
> drivers/ata/pata_hpt366.c | 7 ++++++-
> drivers/ata/pata_hpt3x3.c | 6 ++++++
> drivers/ata/pata_it821x.c | 6 ++++++
> drivers/ata/pata_jmicron.c | 4 ++++
> drivers/ata/pata_marvell.c | 4 ++++
> drivers/ata/pata_mpiix.c | 4 ++++
> drivers/ata/pata_netcell.c | 4 ++++
> drivers/ata/pata_ns87410.c | 4 ++++
> drivers/ata/pata_oldpiix.c | 4 ++++
> drivers/ata/pata_opti.c | 4 ++++
> drivers/ata/pata_optidma.c | 4 ++++
> drivers/ata/pata_pdc202xx_old.c | 4 ++++
> drivers/ata/pata_radisys.c | 4 ++++
> drivers/ata/pata_rz1000.c | 6 ++++++
> drivers/ata/pata_sc1200.c | 4 ++++
> drivers/ata/pata_serverworks.c | 6 ++++++
> drivers/ata/pata_sil680.c | 4 ++++
> drivers/ata/pata_sis.c | 4 ++++
> drivers/ata/pata_triflex.c | 4 ++++
> drivers/ata/pata_via.c | 6 ++++++
> drivers/ata/sata_sil.c | 2 ++
> drivers/ata/sata_sil24.c | 2 ++
> 34 files changed, 165 insertions(+), 1 deletion(-)
>
> Index: work1/drivers/ata/ahci.c
> ===================================================================
> --- work1.orig/drivers/ata/ahci.c
> +++ work1/drivers/ata/ahci.c
> @@ -225,10 +225,12 @@ static void ahci_thaw(struct ata_port *a
> static void ahci_error_handler(struct ata_port *ap);
> static void ahci_vt8251_error_handler(struct ata_port *ap);
> static void ahci_post_internal_cmd(struct ata_queued_cmd *qc);
> +#ifdef CONFIG_PM
> static int ahci_port_suspend(struct ata_port *ap, pm_message_t mesg);
> static int ahci_port_resume(struct ata_port *ap);
> static int ahci_pci_device_suspend(struct pci_dev *pdev, pm_message_t mesg);
> static int ahci_pci_device_resume(struct pci_dev *pdev);
Wouldn't it be simpler to add
#else
#define ahci_port_suspend(port, message) (NULL)
etc (or something similar)?
Regards,
Nigel
next prev parent reply other threads:[~2007-03-03 0:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20061122172841.0b90f042@localhost.localdomain>
[not found] ` <Pine.LNX.4.60.0702262150460.5079@poirot.grange>
2007-02-28 21:19 ` [PATCH] pata_sil680 suspend/resume Guennadi Liakhovetski
2007-03-01 22:11 ` Guennadi Liakhovetski
2007-03-02 8:45 ` [PATCH 1/2 -stable] libata: add missing PM callbacks Tejun Heo
2007-03-02 8:46 ` [PATCH 2/2 -stable] libata: add missing CONFIG_PM in LLDs Tejun Heo
2007-03-03 0:18 ` Nigel Cunningham [this message]
2007-03-03 3:20 ` [linux-pm] " Tejun Heo
2007-03-03 5:34 ` Nigel Cunningham
2007-03-02 22:42 ` [PATCH 1/2 -stable] libata: add missing PM callbacks Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1172881095.18544.108.camel@nigel.suspend2.net \
--to=nigel@nigel.suspend2.net \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=g.liakhovetski@gmx.de \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.osdl.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox