public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-pm@lists.osdl.org
Subject: [PATCH] remove firmware disk mode
Date: Tue, 20 Mar 2007 12:02:53 +0100	[thread overview]
Message-ID: <1174388573.3770.26.camel@johannes.berg> (raw)
In-Reply-To: <20070320102551.GB19283@elf.ucw.cz>

This patch removes the firmware disk suspend mode which is the wrong
approach, it is supposed to be used for implementing firmware-based disk
suspend but cannot actually be used for that.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>

---
 include/linux/pm.h  |   13 ++++++-------
 kernel/power/disk.c |    3 +--
 2 files changed, 7 insertions(+), 9 deletions(-)

--- linux-2.6.orig/include/linux/pm.h	2007-03-20 11:55:22.663214909 +0100
+++ linux-2.6/include/linux/pm.h	2007-03-20 11:56:09.783214909 +0100
@@ -114,13 +114,12 @@ typedef int __bitwise suspend_disk_metho
 
 /* invalid must be 0 so struct pm_ops initialisers can leave it out */
 #define PM_DISK_INVALID		((__force suspend_disk_method_t) 0)
-#define	PM_DISK_FIRMWARE	((__force suspend_disk_method_t) 1)
-#define	PM_DISK_PLATFORM	((__force suspend_disk_method_t) 2)
-#define	PM_DISK_SHUTDOWN	((__force suspend_disk_method_t) 3)
-#define	PM_DISK_REBOOT		((__force suspend_disk_method_t) 4)
-#define	PM_DISK_TEST		((__force suspend_disk_method_t) 5)
-#define	PM_DISK_TESTPROC	((__force suspend_disk_method_t) 6)
-#define	PM_DISK_MAX		((__force suspend_disk_method_t) 7)
+#define	PM_DISK_PLATFORM	((__force suspend_disk_method_t) 1)
+#define	PM_DISK_SHUTDOWN	((__force suspend_disk_method_t) 2)
+#define	PM_DISK_REBOOT		((__force suspend_disk_method_t) 3)
+#define	PM_DISK_TEST		((__force suspend_disk_method_t) 4)
+#define	PM_DISK_TESTPROC	((__force suspend_disk_method_t) 5)
+#define	PM_DISK_MAX		((__force suspend_disk_method_t) 6)
 
 /**
  * struct pm_ops - Callbacks for managing platform dependent suspend states.
--- linux-2.6.orig/kernel/power/disk.c	2007-03-20 11:55:23.353214909 +0100
+++ linux-2.6/kernel/power/disk.c	2007-03-20 11:56:09.783214909 +0100
@@ -304,7 +304,6 @@ late_initcall(software_resume);
 
 
 static const char * const pm_disk_modes[] = {
-	[PM_DISK_FIRMWARE]	= "firmware",
 	[PM_DISK_PLATFORM]	= "platform",
 	[PM_DISK_SHUTDOWN]	= "shutdown",
 	[PM_DISK_REBOOT]	= "reboot",
@@ -357,7 +356,7 @@ static ssize_t disk_store(struct subsyst
 	len = p ? p - buf : n;
 
 	mutex_lock(&pm_mutex);
-	for (i = PM_DISK_FIRMWARE; i < PM_DISK_MAX; i++) {
+	for (i = PM_DISK_PLATFORM; i < PM_DISK_MAX; i++) {
 		if (!strncmp(buf, pm_disk_modes[i], len)) {
 			mode = i;
 			break;

  parent reply	other threads:[~2007-03-20 11:02 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20070320015821.782406000@sipsolutions.net>
2007-03-20  1:58 ` [PATCH] rework pm_ops pm_disk_modes foo Johannes Berg
2007-03-20  8:46   ` [PATCH v2] " Johannes Berg
2007-03-20  9:31     ` Pavel Machek
2007-03-20  9:36       ` Johannes Berg
2007-03-20  9:43         ` Pavel Machek
2007-03-20  9:46           ` Johannes Berg
2007-03-20 10:17           ` [PATCH] add firmware disk state and clean up Johannes Berg
2007-03-20 10:25             ` Pavel Machek
2007-03-20 10:45               ` Johannes Berg
2007-03-20 11:02               ` Johannes Berg [this message]
2007-03-20 13:15                 ` [PATCH] remove firmware disk mode Pavel Machek
2007-03-20 11:06               ` [PATCH] implement pm_ops.valid for everybody Johannes Berg
2007-03-20 13:16                 ` Pavel Machek
2007-03-20 23:44                 ` David Brownell
2007-03-20 22:49                   ` Pavel Machek
2007-03-21 21:01                   ` Guennadi Liakhovetski
2007-03-21 22:07                     ` David Brownell
2007-03-21 22:36                       ` Guennadi Liakhovetski
2007-03-21 22:57                         ` Pavel Machek
2007-03-21 23:25                           ` David Brownell
2007-03-21 23:31                             ` Pavel Machek
2007-03-22 10:03                             ` Johannes Berg
2007-03-22 17:10                               ` David Brownell
2007-03-22 17:18                                 ` Johannes Berg
2007-03-22 18:13                                   ` David Brownell
2007-03-22 18:18                                     ` Johannes Berg
2007-03-21 23:32                           ` Rafael J. Wysocki
2007-03-20 22:59             ` [PATCH] add firmware disk state and clean up David Brownell
2007-03-20 22:09               ` Pavel Machek
2007-03-20 23:31                 ` David Brownell
2007-03-20 11:48   ` [PATCH] rework pm_ops pm_disk_modes foo Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1174388573.3770.26.camel@johannes.berg \
    --to=johannes@sipsolutions.net \
    --cc=linux-pm@lists.osdl.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox