Re: [PATCH] introduce /sys/power/disk_powerdown_mode

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1.1: Type: text/plain, Size: 1093 bytes --]

On Wed, 2007-03-21 at 13:25 +0100, Rafael J. Wysocki wrote:
> On Wednesday, 21 March 2007 10:23, Johannes Berg wrote:
> > This patch introduces /sys/power/disk_powerdown_mode
> 
> I don't think this name is the right one too, since the platform mode is not
> exactly the power down mode (let alone test and testproc).
> 
> > and deprecates /sys/power/disk. The former has the advantages
> >  * a much more expressive name
> 
> Well, please choose another name (I'd probably use disk_mode or something
> like that, but 'disk' is well-documented, so why change it?).

I initially just had 'disk_mode' but then I remembered the confusion
about 'firmware' (which I just removed) and changed it. I can change it
again. Another point for changing it from disk was to let both APIs
coexist.

> >  * contains all valid modes as well as the selected one
> >    in a fashion known from the LED subsystem.
> 
> Pleases review the documentation under Documentation/power and
> Documentation/ABI and update it in accordance with the changes you're making.

Good point.

johannes

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]