From: Johannes Berg <johannes@sipsolutions.net>
To: Pavel Machek <pavel@ucw.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-pm@lists.linux-foundation.org,
Russell King <rmk@arm.linux.org.uk>
Subject: Re: + rework-pm_ops-pm_disk_mode-kill-misuse.patch added to -mm tree
Date: Thu, 22 Mar 2007 11:08:48 +0100 [thread overview]
Message-ID: <1174558128.3944.78.camel@johannes.berg> (raw)
In-Reply-To: <20070322100355.GA6834@elf.ucw.cz>
[-- Attachment #1.1: Type: text/plain, Size: 848 bytes --]
On Thu, 2007-03-22 at 11:03 +0100, Pavel Machek wrote:
> > So they shouldn't offer it in Kconfig?
I agree with that.
> Anyway, this patch is good, as it allows interested ARM machines to
> really disable suspend-to-disk. What they were doing previously was
> not effective.
I thought you just said you understood pm_ops now :->
No, once SOFTWARE_SUSPEND is configured there's *no way* to disable it
after the fact via pm_ops. Read valid_state() in kernel/power/main.c.
But that's a design decision, once the kernel config allows suspend to
disk runtime pm_ops have no say in it. And what they previously did by
nack'ing suspend to disk for platform mode is broken and just papers
over the problem in the default case, once the user puts shutdown
> /sys/power/disk the problem shows up again (if there is any).
johannes
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2007-03-22 10:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-21 23:34 + rework-pm_ops-pm_disk_mode-kill-misuse.patch added to -mm tree akpm
2007-03-22 9:48 ` Russell King
2007-03-22 9:56 ` Andrew Morton
2007-03-22 10:03 ` Pavel Machek
2007-03-22 10:08 ` Johannes Berg [this message]
2007-03-22 13:26 ` Russell King
2007-03-22 13:31 ` Pavel Machek
2007-03-22 13:41 ` Vitaly Wool
2007-03-22 14:03 ` Pavel Machek
2007-03-22 14:27 ` Vitaly Wool
2007-03-22 14:33 ` Pavel Machek
2007-03-22 15:23 ` Johannes Berg
2007-03-22 15:26 ` Vitaly Wool
2007-03-22 14:24 ` Paul Mundt
2007-03-22 14:33 ` Pavel Machek
2007-03-22 14:35 ` Paul Mundt
2007-03-22 17:36 ` Andrew Morton
2007-03-22 17:51 ` Johannes Berg
2007-03-22 15:05 ` Johannes Berg
2007-03-22 15:23 ` Vitaly Wool
2007-03-22 15:28 ` Johannes Berg
-- strict thread matches above, loose matches on Subject: below --
2007-03-22 18:00 akpm
2007-04-27 22:11 ` Johannes Berg
2007-04-27 22:55 ` Andrew Morton
2007-04-28 6:40 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1174558128.3944.78.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=akpm@linux-foundation.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=pavel@ucw.cz \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox