From: Johannes Berg <johannes@sipsolutions.net>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-pm@lists.linux-foundation.org
Subject: Re: [PATCH] remove software_suspend() and fix compile w/ SOFTWARE_SUSPEND disabled
Date: Sun, 25 Mar 2007 20:18:32 +0200 [thread overview]
Message-ID: <1174846713.20440.32.camel@johannes.berg> (raw)
In-Reply-To: <20070325163417.GB9958@ucw.cz>
[-- Attachment #1.1: Type: text/plain, Size: 644 bytes --]
On Sun, 2007-03-25 at 16:34 +0000, Pavel Machek wrote:
> > @@ -60,7 +60,7 @@ acpi_system_write_sleep(struct file *fil
> > state = simple_strtoul(str, NULL, 0);
> > #ifdef CONFIG_SOFTWARE_SUSPEND
> > if (state == 4) {
> > - error = software_suspend();
> > + error = pm_suspend(PM_SUSPEND_DISK);
> > goto Done;
> > }
>
> Is enter_state and pm_suspend equivalent? Why the change?
Yeah, except that enter_state() has more argument checking. The change
was just because I didn't see much point in having two entry points for
the same thing and killed off software_suspend() completely. Don't
really care.
johannes
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2007-03-25 18:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-22 13:46 [PATCH] remove software_suspend() and fix compile w/ SOFTWARE_SUSPEND disabled Johannes Berg
2007-03-22 21:12 ` Rafael J. Wysocki
2007-03-23 13:46 ` Johannes Berg
2007-03-25 16:34 ` Pavel Machek
2007-03-25 18:18 ` Johannes Berg [this message]
2007-03-25 19:53 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1174846713.20440.32.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=linux-pm@lists.linux-foundation.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox